You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/08/25 23:44:46 UTC

[GitHub] gianm commented on issue #6220: Fix four bugs with numeric dimension output types.

gianm commented on issue #6220: Fix four bugs with numeric dimension output types.
URL: https://github.com/apache/incubator-druid/pull/6220#issuecomment-416003575
 
 
   Fwiw, I had already started addressing some of those comments, so I plan to raise a follow up PR for that.
   
   Btw, @leventov what did you intend by doing an approval + also leaving comments? I'd interpret that as "please consider these comments, but if you don't want to do them, I am ok with that." I thought they were all reasonable comments so that's why I'm doing a follow up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org