You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kladderadeng (via GitHub)" <gi...@apache.org> on 2025/03/19 16:26:49 UTC

[I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

kladderadeng opened a new issue, #10588:
URL: https://github.com/apache/cloudstack/issues/10588

   ### problem
   
   We killed a bunch of our VMs due to this and I am pretty sure that this behavior cannot be intended, so I post it as a bug. I hope this is the correct way.
   
   We created a bunch of (Windows) VM Instances by uploading the Windows ISO file, setting the OS Type to Windows Server 2022 and then creating instances based on that ISO (create a new instance, boot the ISO, install Windows...).
   After the installation we usually disconnect the ISO from the instance.
   Now to test various OS types, we changed the OS type on the ISO file and found out that all VMs that originated from that ISO got their OS type changed too.
   
   This lead to all the affected VMs to boot into a BSOD (Bluescreen) and we could not fix them, so we had to recreate those instances from scratch.
   
   It is a test environment, so no harm was done.
   
   
   ### versions
   
   OS Ubuntu 24.04
   Apache Cloudstack 4.20.0.0 installed via the ACS Quickstart guide, so not compiled from source here!
   Hypervisor KVM QEMU emulator version 8.2.2
   Libvirtd v 10.0.0
   
   ### The steps to reproduce the bug
   
   1. Upload a ISO (Windows Server 2022 Evaluation in our case) and set the OS Type to Windows Server 2022
   2. Create a new instance based on that ISO and turn it on, install Windows etc.
   3. Disconnect the ISO from the Instance
   4. Create as many Instances that way as you want
   5. Go back to the ISO Image and change the OS Type to for example Other PV 64 Bit
   6. In the ISO Image click on Instances to see which Instances are connected to this ISO. If you disconnected the ISO after the Instance creation / Windows installation, this list will be empty. No visible connection to an instance exists.
   7. Check your instances and observe that the OS type changed for all of them from Windows Server 2022 to Other PV 64 Bit
   8. You can repeat steps 5-6 as often as you want, the OS type of the instances that do not seem to have any connection to the ISO are always changing.
   
   
   ### What to do about it?
   
   I do not know. I suspect that there is a reference in the Database somewhere telling ACS that all instances that where installed from a particular ISO / Image still get the OS Type passed down.
   
   In my point of view, an ISO Image should never have any reference to an Instance when it is not connected anymore. And it for sure should not affect the OS Type of an instance when I change the OS type of an ISO Image. The OS Type of a Instance should only be changed when changing it on the instance.
   
   The way it behaves currently is not obvious, unpredictable (you do not know which instances will be affected if you have hundreds) and dangerous if you have production workload.
   
   The big issue here is, that with the change of the OS type from an ISO, you can basically kill all your VMs at once and there is no warning / nothing you can do about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti closed issue #10588: ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances
URL: https://github.com/apache/cloudstack/issues/10588


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "kladderadeng (via GitHub)" <gi...@apache.org>.
kladderadeng commented on issue #10588:
URL: https://github.com/apache/cloudstack/issues/10588#issuecomment-2751423010

   @DaanHoogland I would be fine with that. Making the OS type not-changable after upload would be a clear indicator for the user what to expect and would prevent the currently not so clear consequences when making changes afterwards. I would welcome your proposed change very much.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on issue #10588:
URL: https://github.com/apache/cloudstack/issues/10588#issuecomment-3102669331

   OS type update for the existing VMs is addressed in #11215 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #10588:
URL: https://github.com/apache/cloudstack/issues/10588#issuecomment-2743260686

   @kladderadeng 
   When update guest OS type of template or ISO, the VMs created from the template/ISO will use the new guest OS.
   
   I agree it makes more sense not to update guest OS of VM if ISO is detached from the VM.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "kladderadeng (via GitHub)" <gi...@apache.org>.
kladderadeng commented on issue #10588:
URL: https://github.com/apache/cloudstack/issues/10588#issuecomment-2750285517

   The issue I have is not that it is possible to change the OS Type retroactively on an uploaded ISO. I am sure there are usecases (someone makes a mistake or wants to find the best OS type for a particular ISO).
   
   My issue is, that changing the ISO / Image OS type, changes all Instances that where once created by that ISO and there is
   a) no indicator that this is going to happen
   b) there seems to be no way to prevent someone doing that (on purpose or by accident)
   c) there is no visible connection between the ISO and the Instances that show which instances will be affected
   
   If we continue with ACS, we will host hundreds of Windows VMs on it. Knowing that we can destroy the whole fleet of VMs by making a single change on an ISO does not make me sleep well. It is not like you select all Instances, click on delete, then on OK. You make a change on a part of the infrastructure that does not have any visible connection to the instances anymore, but it making changes to them.
   
   This is really worrying to me.
   
   If I were to make a wish, I either
   - wish there would be no invisible connection between ISOs and Instances. Personally I do not see a usecase why I would change the OS type of all Instances that originated from a particular ISO by changing the OS type of the ISO. I would change the OS Type of the particular instance directly.
   - If this behavior is intended, having a global setting that prevents to change the OS type of an ISO retroactively would prevent a disaster that is about to happen with the current behavior, at least for Windows VMs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "NuxRo (via GitHub)" <gi...@apache.org>.
NuxRo commented on issue #10588:
URL: https://github.com/apache/cloudstack/issues/10588#issuecomment-2750851715

   @kladderadeng @weizhouapache 
   
   This is surprising to me as well, not noticed the behaviour in my many years using Cloudstack, but perhaps that is because I always went with all templates/ISOs/etc using "virtio" devices.
   
   If we were to enhance this I would go for your second suggestion, make this automatic "inheritance" operation togglable in the Global Options, something like "Inherit OS Type changes from source ISO/template" (inherit.ostype.changes).
   The current behaviour should remain default as to not break expectations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #10588:
URL: https://github.com/apache/cloudstack/issues/10588#issuecomment-2747626035

   @kladderadeng , I see your wonder, but what is the use case of changing the guestos type of a readonly medium is. the ISO content didn't change did it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] ISO Image OS Type is tied to the Instance, even after the ISO is disconnected, changes affect all Instances [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #10588:
URL: https://github.com/apache/cloudstack/issues/10588#issuecomment-2750866401

   ok, @weizhouapache @kladderadeng @NuxRo , I would personally disallow any change of os-type on entities that ar supposed to be readonly (templates, ISOs) as they can easily be uploaded again with a different os type without any conflicts. 
   
   So -0 on this. I think it is complicating things unnecessarily.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org