[GitHub] [arrow] zeroshade commented on a diff in pull request #13868: ARROW-17359: [Go][FlightSQL] Create Example with SQLite in-mem and use to test FlightSQL server

[GitBox <gi...@apache.org>]

zeroshade commented on code in PR #13868:
URL: https://github.com/apache/arrow/pull/13868#discussion_r945825651


##########
go/arrow/array/list.go:
##########
@@ -321,12 +321,31 @@ func NewListBuilder(mem memory.Allocator, etype arrow.DataType) *ListBuilder {
 	}
 }
 
+// NewListBuilderWithField takes a field to use for the child rather than just
+// a datatype to allow for more customization.
+func NewListBuilderWithField(mem memory.Allocator, field arrow.Field) *ListBuilder {

Review Comment:
   I actually ended up creating this because of the flightsql tests failing without it, haha. In addition, all the tests that simply use `NewBuilder` rather than hitting NewListBuilder` are testing it too now. Since the switch in NewBuilder uses this. I'll add a small test for it directly though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org