You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by ar...@apache.org on 2016/05/25 15:56:21 UTC

[1/2] storm git commit: Ack late tuples in windowed mode

Repository: storm
Updated Branches:
  refs/heads/1.x-branch 1a5b1dc56 -> 2425f27f1


Ack late tuples in windowed mode

The current implementation simply ignores late tuples without acking
them, which causes timeouts and replays after
TOPOLOGY_MESSAGE_TIMEOUT_SECS. A tuple which was late at a some time
is going to be late at any moment in the future, so there is no point
of replaying it, because the lingering late tuples will just block the
topology (especially if TOPOLOGY_MAX_SPOUT_PENDING is set).


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/0d5ed75b
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/0d5ed75b
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/0d5ed75b

Branch: refs/heads/1.x-branch
Commit: 0d5ed75b7a05ce026cf3180f229de0ccdd3c2cb2
Parents: 1a5b1dc
Author: Balazs Kossovics <ba...@s4m.io>
Authored: Fri May 20 17:36:42 2016 +0200
Committer: Arun Mahadevan <ai...@hortonworks.com>
Committed: Wed May 25 21:24:26 2016 +0530

----------------------------------------------------------------------
 .../src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java     | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/0d5ed75b/storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java b/storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java
index ab2fe86..9439ef2 100644
--- a/storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java
+++ b/storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java
@@ -268,6 +268,7 @@ public class WindowedBoltExecutor implements IRichBolt {
             if (waterMarkEventGenerator.track(input.getSourceGlobalStreamId(), ts)) {
                 windowManager.add(input, ts);
             } else {
+                windowedOutputCollector.ack(input);
                 LOG.info("Received a late tuple {} with ts {}. This will not processed.", input, ts);
             }
         } else {


[2/2] storm git commit: Added STORM-1859 to Changelog

Posted by ar...@apache.org.
Added STORM-1859 to Changelog


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/2425f27f
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/2425f27f
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/2425f27f

Branch: refs/heads/1.x-branch
Commit: 2425f27f1d9cb179513f6b46de47039b95a3d8a7
Parents: 0d5ed75
Author: Arun Mahadevan <ai...@hortonworks.com>
Authored: Wed May 25 21:25:24 2016 +0530
Committer: Arun Mahadevan <ai...@hortonworks.com>
Committed: Wed May 25 21:25:24 2016 +0530

----------------------------------------------------------------------
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/2425f27f/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0815c6c..a97dd34 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,5 @@
 ## 1.1.0
+ * STORM-1859: Ack late tuples in windowed mode
  * STORM-1851: Fix default nimbus impersonation authorizer config
  * STORM-1848: Make KafkaMessageId and Partition serializable to support
  * STORM-1862: Flux ShellSpout and ShellBolt can't emit to named streams