You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/01/24 08:16:35 UTC

[GitHub] jixuan1989 commented on a change in pull request #25: Fix sonar

jixuan1989 commented on a change in pull request #25: Fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/25#discussion_r250497358
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/conf/directories/strategy/MaxDiskUsableSpaceFirstStrategy.java
 ##########
 @@ -60,7 +60,7 @@ public int getMaxSpaceFolder() {
   }
 
   private long getUsableSpace(String path) {
-    double freespace = new File(path).getUsableSpace() / dataSizeShift;
+    double freespace = new File(path).getUsableSpace() / DATA_SIZE_SHIFT;
     return (long) freespace;
 
 Review comment:
   also strange.... why the method returns a long value?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services