You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/03 01:39:51 UTC

[GitHub] [samza] cameronlee314 commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync

cameronlee314 commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386751213
 
 

 ##########
 File path: gradle/maven.gradle
 ##########
 @@ -22,13 +22,13 @@ subprojects {
   publishing {
     publications {
       mavenJava(MavenPublication) {
-        from components.java
-        if(project.name == 'samza-shell') {
-          artifact shellTarGz {
-            classifier "dist"
 
 Review comment:
   Will there be an impact to the artifact name if `classifier "dist"` is removed here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services