You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/11/29 15:31:46 UTC
[GitHub] [logging-log4j2] carterkozak opened a new pull request #443: LOG4J2-2967: Fix JTL parameter resolution for messages with too few parameters
carterkozak opened a new pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443
When messages don't contain enough parameters, index-based lookups
result in a JSON null token rather than failing to produce a log event.
This change also modifies behavior of non-index-based resolution
when messages have no parameters. Previously the value would be null,
now we produce an empty list. Note that this is a change for only
ParameterizedMessage, not for messages which implement
ParameterVisitable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak commented on pull request #443: LOG4J2-2967: Fix JTL parameter resolution for messages with too few parameters
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443#issuecomment-735411858
@vy I'd appreciate your review on this at your convenience :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #443: LOG4J2-2967 Fix JTL parameter resolution for messages with too few parameters.
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443#issuecomment-735649229
@carterkozak Great catch with a complete fix! Thanks so much for sparing time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy merged pull request #443: LOG4J2-2967 Fix JTL parameter resolution for messages with too few parameters.
Posted by GitBox <gi...@apache.org>.
vy merged pull request #443:
URL: https://github.com/apache/logging-log4j2/pull/443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org