You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hawq.apache.org by outofmem0ry <gi...@git.apache.org> on 2017/07/03 23:50:49 UTC

[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...

GitHub user outofmem0ry opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1263

    HAWQ-1495 Corrected answer file to match insert statement

    In `src/test/feature/query/sql/rowtypes.sql` the value inserted into the table is `"insert into people values ('(Joe,Blow)', '1984-01-10');"`, where date is in the format - `1984-01-10`. But in `src/test/feature/query/ans/rowtypes.ans`, whenever doing a "select * from people" the answer is stored as `01-10-1984`. This causes the test to fail. Corrected the date format and test executes successfully. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/outofmem0ry/incubator-hawq feature/TestRowTypes-HAWQ-1495

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1263
    
----
commit 3a6d182462ac237883b8f5702dc74ea212dcfc07
Author: Shubham Sharma <sh...@gmail.com>
Date:   2017-07-03T23:40:19Z

    HAWQ-1495 Corrected answer file to match insert statements

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by paul-guo- <gi...@git.apache.org>.

Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    You could run the test using parallel-run-feature-test.sh.
    
    Basically the test need to set some properties so that ans files are uniform.
    In parallel-run-feature-test.sh, e.g. the date style is set as below,
    
      run_sql "alter database $TEST_DB_NAME set datestyle to 'postgres,MDY';"
    
    An ideal fix for this is to document it in readme, warning not to run googletest directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by radarwave <gi...@git.apache.org>.

Github user radarwave commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    @outofmem0ry There is no jira number in your commit, I have add it and merged this commit.  Please close this PR. Thanks.


---

[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...

Posted by outofmem0ry <gi...@git.apache.org>.

Github user outofmem0ry commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1263#discussion_r127881478

--- Diff: src/test/feature/README.md ---
@@ -16,7 +16,10 @@ Before building the code of feature tests part, just make sure your compiler sup
2. Load environment configuration by running `source $INSTALL_PREFIX/greenplum_path.sh`.
3. Load hdfs configuration. For example, `export HADOOP_HOME=/Users/wuhong/hadoop-2.7.2 && export PATH=${PATH}:${HADOOP_HOME}/bin`. Since some test cases need `hdfs` and `hadoop` command, just ensure these commands work before running. Otherwise you will get failure.
4. Run the cases with`./parallel-run-feature-test.sh 8 ./feature-test`(in this case 8 threads in parallel), you could use `--gtest_filter` option to filter test cases(both positive and negative patterns are supported). Please see more options by running `./feature-test --help`.
-5.You can also run cases with `./parallel-run-feature-test.sh 8 ./feature-test --gtest_schedule` (eg. --gtest_schedule=./full_tests.txt) if you want to run cases in both parallel way and serial way.The schedule file sample is full_tests.txt which stays in the same directory.
+5. You can also run cases with `./parallel-run-feature-test.sh 8 ./feature-test --gtest_schedule` (eg. --gtest_schedule=./full_tests.txt) if you want to run cases in both parallel way and serial way.The schedule file sample is full_tests.txt which stays in the same
+directory.
--- End diff --

@paul-guo- Done.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by outofmem0ry <gi...@git.apache.org>.

Github user outofmem0ry commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    @radarwave Done. Thank you for the review


---

[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...

Posted by paul-guo- <gi...@git.apache.org>.

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1263#discussion_r127877655

It looks like 4 and 5 could be combined.

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by paul-guo- <gi...@git.apache.org>.

Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by radarwave <gi...@git.apache.org>.

Github user radarwave commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by outofmem0ry <gi...@git.apache.org>.

Github user outofmem0ry commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    @paul-guo- @radarwave do you need any other inputs needed from my side ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by outofmem0ry <gi...@git.apache.org>.

Github user outofmem0ry commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    @paul-guo- updated the doc as per the review comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1263: HAWQ-1495 Corrected answer file to match ...

Posted by outofmem0ry <gi...@git.apache.org>.

Github user outofmem0ry closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1263


---

[GitHub] incubator-hawq issue #1263: HAWQ-1495 Corrected answer file to match insert ...

Posted by radarwave <gi...@git.apache.org>.

Github user radarwave commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1263
  
    @outofmem0ry Please squash your commits and rewrite the commit messages as now the answer file is not changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---