[GitHub] tiles pull request: Object-Type Attribute Value Evaluation

[brettryan <gi...@git.apache.org>]

GitHub user brettryan opened a pull request:

    https://github.com/apache/tiles/pull/4

    Object-Type Attribute Value Evaluation

    Object type attributes such as the `<menu />` implementation may now implement `o.a.t.awareness.ExpressionAware` which causes `#evaluateExpressions(AttributeEvaluator,Request)` to be called during attribute evaluation.
    
    It is up to the implementation to handle evaluation using the supplied evaluator.
    
    Implementors may return any object type or a duplicated of itself with expressions replaced which will be used for rendering within the view model.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brettryan/tiles TILES_3_0_X

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tiles/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit a56d124c9177d9f424b7390180659e5b01a4791e
Author: Brett Ryan <br...@gmail.com>
Date:   2015-06-14T23:49:29Z

    Added git ignore/attributes.

commit 0312ece161c23aa4b75ab647d8966b68943ce971
Author: Brett Ryan <br...@gmail.com>
Date:   2015-06-14T23:50:00Z

    Added support for simple object expression evaluation.
    
    Object type attributes such as the <menu /> implementation may now implement
    o.a.t.awareness.ExpressionAware which will be provided the opertunitiy for
     #evaluateExpressions(AttributeEvaluator,Request) to be called.
    
    It is up to the implementation to handle evaluation using the supplied
    evaluator.

commit 70b0288d22f80a90bbda618072936b6668f5333d
Author: Brett Ryan <br...@gmail.com>
Date:   2015-06-15T04:33:08Z

    Corrected trailing comma in toString.

commit 38611303f98b52758f35de068efe9473689a4993
Author: Brett Ryan <br...@gmail.com>
Date:   2015-06-15T04:34:28Z

    Corrected evaluation to not overwrite the model.
    
    I mistakenly thought the object instances were per request. It was necessary
    to change this to return values instead of updating themselves.

commit ea4e190753478d3e1ff8082fd8ca5d2fb08ff64e
Author: Brett Ryan <br...@gmail.com>
Date:   2015-06-15T04:42:04Z

    Corrected @since doctag.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---