You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ppatierno <gi...@git.apache.org> on 2017/10/25 10:40:55 UTC

[GitHub] kafka pull request #4132: KAFKA-5925: Adding records deletion operation to t...

GitHub user ppatierno opened a pull request:

    https://github.com/apache/kafka/pull/4132

    KAFKA-5925: Adding records deletion operation to the new Admin Client API

    This is the PR related to the [KIP-204](https://cwiki.apache.org/confluence/display/KAFKA/KIP-204+%3A+Adding+records+deletion+operation+to+the+new+Admin+Client+API) in order to add the `deleteRecords` operation to the new Admin Client (it's already available in the "legacy" one).
    Other than that, unit test and integration tests are added as well (such integration tests come from the "legacy" integration tests in order to test the new addition in the same way as the "legacy" one).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppatierno/kafka kafka-5925

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4132
    
----
commit a2f25eb7337ddea8d421b9e7cc8b3b9adf0349c6
Author: Paolo Patierno <pp...@live.com>
Date:   2017-09-28T16:33:56Z

    Started to add skeleton about delete records operation on Admin Client

commit 1781192e062f50e720bf44f4c2265ea4ea45577e
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-03T13:54:41Z

    Added first skeleton for deleteRecords method in the Admin Client

commit 4bd2c2112dc310bacb963e4f28bb14472c009a15
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-04T08:41:37Z

    Completed the DeleteRecordsResult
    Added handle response logic for the deleteRecords operation

commit d4ad3fd6a5e4d9f89ffb320de6de5701f6127d44
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-04T10:09:04Z

    Fixed wrong checking on no error condition

commit e45292004f98c35c93e4d0c4ca6b890e5285044f
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-04T10:54:20Z

    Added a unit test on Admin Client delete records operation

commit 016fb425ad3b27e2d2b22c87539a1fff34842753
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-05T07:40:53Z

    Updated inheritance of AdminClientIntegrationTest from IntegrationTestHarness for consumer/producer support (delete records tests to add)

commit af8162ab3f57b2f60c08c47f1d644bba62d93552
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-20T09:22:48Z

    Added DeleteRecords class for wrapping long offset

commit 1e716f3c57382f8a8f66e81974d7d597dc076f8e
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-20T09:32:50Z

    Updated AdminClient interface and implementation with new DeleteRecords class

commit 7c83dbce7b8b23d0ba51ec99f51180442f5e7e80
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-23T07:53:13Z

    Renamed DeleteRecords to DeleteRecordsTarget

commit fbbccea767afa302e821652fe2b0c07e8e91a395
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-23T15:51:02Z

    Modified getting metadata strategy using a nested Call approach (metadata then delete records request)
    Added integration tests as "legacy" admin client tests
    Added a unit test

commit 9e1051620f2f34cbb2a1dfa03c209ab49de9ebd8
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-23T16:18:07Z

    Minor fix on creating Map instances

commit db60a16bc6e21d12318ba52f64cbc7effb32f469
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-24T09:03:54Z

    Renamed DeleteRecordsTarget to RecordsToDelete with related methods
    Fixed not working unit test for records deletion

commit 749b4076261f24aac582ed8f059c41a7c25cc5b2
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-25T09:00:04Z

    Minor fixes on unit and integration tests

commit 520441183c202f24ff86b375189e25f51142bb32
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-25T09:13:32Z

    Fixed some style errors after checking

commit 599e604d5bb774e5bd90b354a16cf31883b10ae5
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-25T10:13:27Z

    Fixed conflict with trunk

commit ab718b0e6bd5c1afe82803a11ca4bc2e0979e345
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-25T10:19:31Z

    Merge branch 'trunk' into kafka-5925

commit 80895bf4adfba517c376a0685efe8ec5de7f17c6
Author: Paolo Patierno <pp...@live.com>
Date:   2017-10-25T10:35:42Z

    Fixed conflict on generateConfigs method

----


---

[GitHub] kafka pull request #4132: KAFKA-5925: Adding records deletion operation to t...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/4132


---