You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/07 22:43:41 UTC

[jira] [Commented] (GROOVY-8048) final fields for pre-compiled traits aren't processed correctly

    [ https://issues.apache.org/jira/browse/GROOVY-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856949#comment-15856949 ] 

ASF GitHub Bot commented on GROOVY-8048:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/492

    GROOVY-8048: final fields for pre-compiled traits aren't processed co…

    …rrectly

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy8048

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #492
    
----
commit 75a7ca85258bafe9833771714b143941121d4762
Author: paulk <pa...@asert.com.au>
Date:   2017-02-07T22:41:11Z

    GROOVY-8048: final fields for pre-compiled traits aren't processed correctly

----


> final fields for pre-compiled traits aren't processed correctly
> ---------------------------------------------------------------
>
>                 Key: GROOVY-8048
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8048
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.8
>            Reporter: Paul King
>
> From slack:
> Testing 2.4.8 by running through the Grails tests (master branch) and seeing NPE's on some tests that exercise Traits.  Can be fairly quickly replicated by running `./gradlew :grails-plugin-interceptors:test`
> same tests pass in 2.4.7 up thru commit https://github.com/apache/groovy/commit/c00a75a89a15e46c2afacf6e72256cd4484bd5f1  which causes the tests to fail with NPE's, don't have a lot of time to look into it, just wanted to mention it
> the Trait class has a final property in it and when it's used it's null, removing the final modifier gets rid of the problem https://github.com/grails/grails-core/blob/master/grails-plugin-interceptors/src/main/groovy/grails/artefact/Interceptor.groovy#L113



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)