You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "spmallette (via GitHub)" <gi...@apache.org> on 2023/04/18 18:38:01 UTC
[GitHub] [tinkerpop] spmallette opened a new pull request, #2026: TINKERPOP-2855 Refactored strategy application
spmallette opened a new pull request, #2026:
URL: https://github.com/apache/tinkerpop/pull/2026
https://issues.apache.org/jira/browse/TINKERPOP-2855
https://issues.apache.org/jira/browse/TINKERPOP-2888
Removed some recursion. Added `Traversal.lock()` to offer a formal way to finalize a traversal. Offers a significant performance improvement. Removed expectation that Graph and related metadata for a `Traversal` is available in child traversals.
On TINKERPOP-2855 the script demonstrating the slowdown was running at 9.1 seconds on my system for 3.5.5. With this change it is executing at 1.7 seconds.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2026: TINKERPOP-2855 Refactored strategy application
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2026:
URL: https://github.com/apache/tinkerpop/pull/2026#issuecomment-1516596337
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #2026: TINKERPOP-2855 Refactored strategy application
Posted by "lyndonbauto (via GitHub)" <gi...@apache.org>.
lyndonbauto commented on PR #2026:
URL: https://github.com/apache/tinkerpop/pull/2026#issuecomment-1515258812
VOTE+1
Reviewed code and tried this change locally on Aerospike Graph. I had a query that was heavy on coalesce use and found that strategies were taking ~120 ms on this specific query for my local system. This change dropped the time to apply strategies to 10 ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #2026: TINKERPOP-2855 Refactored strategy application
Posted by "lyndonbauto (via GitHub)" <gi...@apache.org>.
lyndonbauto commented on code in PR #2026:
URL: https://github.com/apache/tinkerpop/pull/2026#discussion_r1171766037
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversal.java:
##########
@@ -435,4 +437,4 @@ public int hashCode() {
}
return result;
}
-}
+}
Review Comment:
Nit - add new line.
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #2026: TINKERPOP-2855 Refactored strategy application
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette merged PR #2026:
URL: https://github.com/apache/tinkerpop/pull/2026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2026: TINKERPOP-2855 Refactored strategy application
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2026:
URL: https://github.com/apache/tinkerpop/pull/2026#issuecomment-1513660499
## [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2026](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18067b2) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/b77a0166be7198a80dc7f7dd775d3342284daf76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b77a016) will **decrease** coverage by `0.04%`.
> The diff coverage is `82.14%`.
```diff
@@ Coverage Diff @@
## 3.5-dev #2026 +/- ##
=============================================
- Coverage 69.36% 69.32% -0.04%
+ Complexity 8962 8956 -6
=============================================
Files 866 866
Lines 41227 41229 +2
Branches 5434 5434
=============================================
- Hits 28598 28583 -15
- Misses 10714 10736 +22
+ Partials 1915 1910 -5
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cess/remote/traversal/AbstractRemoteTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3JlbW90ZS90cmF2ZXJzYWwvQWJzdHJhY3RSZW1vdGVUcmF2ZXJzYWwuamF2YQ==) | `5.26% <0.00%> (-0.30%)` | :arrow_down: |
| [...tinkerpop/gremlin/process/traversal/Traversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9UcmF2ZXJzYWwuamF2YQ==) | `76.74% <ø> (ø)` | |
| [...gremlin/process/traversal/util/EmptyTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL0VtcHR5VHJhdmVyc2FsLmphdmE=) | `37.50% <0.00%> (-1.21%)` | :arrow_down: |
| [...emlin/process/traversal/util/DefaultTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL0RlZmF1bHRUcmF2ZXJzYWwuamF2YQ==) | `84.61% <84.21%> (+0.12%)` | :arrow_up: |
| [...cess/traversal/lambda/AbstractLambdaTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9sYW1iZGEvQWJzdHJhY3RMYW1iZGFUcmF2ZXJzYWwuamF2YQ==) | `59.64% <100.00%> (-13.08%)` | :arrow_down: |
| [...aversal/strategy/decoration/PartitionStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9kZWNvcmF0aW9uL1BhcnRpdGlvblN0cmF0ZWd5LmphdmE=) | `83.23% <100.00%> (ø)` | |
| [...remlin/process/traversal/util/TraversalHelper.java](https://codecov.io/gh/apache/tinkerpop/pull/2026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC91dGlsL1RyYXZlcnNhbEhlbHBlci5qYXZh) | `85.60% <100.00%> (+0.11%)` | :arrow_up: |
... and [11 files with indirect coverage changes](https://codecov.io/gh/apache/tinkerpop/pull/2026/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org