You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2012/10/06 19:29:55 UTC
Name for org.apache.logging.log4j.message.Message.getMessageFormat()
Hi All
Can we rename Message.*getMessageFormat*() to *getFormat*()?
Especially considering that the subinterface
org.apache.logging.log4j.message.MultiformatMessage defines *getFormats*()
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Name for org.apache.logging.log4j.message.Message.getMessageFormat()
Posted by Ralph Goers <ra...@dslextreme.com>.
I'm not surprised. Nothing does much of anything with the unformatted message. I suppose it would be good to have the methods just for code coverage.
Ralph
On Oct 6, 2012, at 1:59 PM, Gary Gregory wrote:
> Done.
>
> Oddly, none of the test cases where changed.
>
> Gary
>
> On Sat, Oct 6, 2012 at 1:47 PM, Ralph Goers <ra...@dslextreme.com> wrote:
> Sounds OK to me.
>
> Ralph
>
> On Oct 6, 2012, at 10:29 AM, Gary Gregory wrote:
>
>> Hi All
>>
>> Can we rename Message.getMessageFormat() to getFormat()?
>>
>> Especially considering that the subinterface org.apache.logging.log4j.message.MultiformatMessage defines getFormats()
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
>> Spring Batch in Action: http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: Name for org.apache.logging.log4j.message.Message.getMessageFormat()
Posted by Gary Gregory <ga...@gmail.com>.
Done.
Oddly, none of the test cases where changed.
Gary
On Sat, Oct 6, 2012 at 1:47 PM, Ralph Goers <ra...@dslextreme.com>wrote:
> Sounds OK to me.
>
> Ralph
>
> On Oct 6, 2012, at 10:29 AM, Gary Gregory wrote:
>
> Hi All
>
> Can we rename Message.*getMessageFormat*() to *getFormat*()?
>
> Especially considering that the subinterface
> org.apache.logging.log4j.message.MultiformatMessage defines *getFormats*()
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977/>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Name for org.apache.logging.log4j.message.Message.getMessageFormat()
Posted by Ralph Goers <ra...@dslextreme.com>.
Sounds OK to me.
Ralph
On Oct 6, 2012, at 10:29 AM, Gary Gregory wrote:
> Hi All
>
> Can we rename Message.getMessageFormat() to getFormat()?
>
> Especially considering that the subinterface org.apache.logging.log4j.message.MultiformatMessage defines getFormats()
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory