You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/24 22:58:16 UTC

[GitHub] [trafficcontrol] rawlinp opened a new pull request #5884: Fix Traffic Vault postgres backend to match Riak backend for empty URI signing keys

rawlinp opened a new pull request #5884:
URL: https://github.com/apache/trafficcontrol/pull/5884


   ## What does this PR (Pull Request) do?
   
   Make the Traffic Vault Postgres backend return the same JSON response as the Riak
   backend when the delivery service has no URI signing keys.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   - Traffic Vault
   
   ## What is the best way to verify this PR?
   Run the added TO API test with the Postgres Traffic Vault backend configured, followed by the Riak Traffic Vault backend, and verify both pass.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] Bugfix, no docs necessary
   - [x] No changelog necessary, unreleased bug
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   I'm not 100% sure if this disparity between the responses provided by the Postgres and Riak Traffic Vault backends in this case even causes any real world problems, but I'd rather be safe than sorry, especially since it is a simple fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mattjackson220 merged pull request #5884: Fix Traffic Vault postgres backend to match Riak backend for empty URI signing keys

Posted by GitBox <gi...@apache.org>.
mattjackson220 merged pull request #5884:
URL: https://github.com/apache/trafficcontrol/pull/5884


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org