You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/08 16:16:31 UTC
[GitHub] [tvm] leandron opened a new pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
leandron opened a new pull request #8212:
URL: https://github.com/apache/tvm/pull/8212
Expose list of `PassContext` configurations to the Python APIs:
* Expose C++ `PassContext::ListAllConfigs()` via its Python counterpart `tvm.ir.transform.PassContext.list_configs()
* Add unit tests for the C++ and Python layers
* In a follow-up PR we'll use this API to set configurations using `tvmc`
cc @Mousius @gromero @manupa-arm @areusch for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zhiics commented on a change in pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #8212:
URL: https://github.com/apache/tvm/pull/8212#discussion_r648295913
##########
File path: python/tvm/ir/transform.py
##########
@@ -120,6 +120,11 @@ def current():
"""Return the current pass context."""
return _ffi_transform_api.GetCurrentPassContext()
+ @staticmethod
+ def list_configs():
Review comment:
chang this api name as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8212:
URL: https://github.com/apache/tvm/pull/8212#discussion_r648305205
##########
File path: python/tvm/ir/transform.py
##########
@@ -120,6 +120,11 @@ def current():
"""Return the current pass context."""
return _ffi_transform_api.GetCurrentPassContext()
+ @staticmethod
+ def list_configs():
Review comment:
Done, thanks. Do you mind merging it once CI finishes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8212:
URL: https://github.com/apache/tvm/pull/8212#issuecomment-857111753
> LGTM. A nit about the API name. `ListAllConfigs` seems a bit confusing, as it is actually listing the config names without their values. Maybe `ListConfigNames` might be better.
Makes sense, thanks @comaniac I've just renamed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8212:
URL: https://github.com/apache/tvm/pull/8212#issuecomment-857480736
cc @mbaret can you also review and possibly merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #8212:
URL: https://github.com/apache/tvm/pull/8212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8212:
URL: https://github.com/apache/tvm/pull/8212#issuecomment-857085989
CC: @zhiics @comaniac @kevinthesun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #8212:
URL: https://github.com/apache/tvm/pull/8212#issuecomment-858015437
Thanks @leandron @mbaret @zhiics @zackcquic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8212: [IR] Expose list of PassContext configuration names to the Python APIs
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8212:
URL: https://github.com/apache/tvm/pull/8212#issuecomment-858012625
> Hi @leandron:
>
> LGTM.
>
> May I know what kind of features (next PR as you mentioned before) depend on this change?
Hi @zackcquic yes, sure. I'm working on a PR to give `tvmc` the ability to set some PassContext configurations (the ones that can accept simple values) via the command line.
I'm actually going to update this PR to also be able to pass the types of the PassContext configurations, so that I can present better messages.
I have the `tvmc` changes already done, just thought that separate PRs for the changes was more appropriate, that's is why the tvmc changes are not added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org