You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aaron T. Myers (JIRA)" <ji...@apache.org> on 2011/04/08 08:01:07 UTC
[jira] [Created] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
HADOOP-7202 broke TestDFSShell in HDFS
--------------------------------------
Key: HADOOP-7216
URL: https://issues.apache.org/jira/browse/HADOOP-7216
Project: Hadoop Common
Issue Type: Bug
Components: test
Affects Versions: 0.23.0
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
Fix For: 0.23.0
Attachments: hadoop-7216.0.txt
The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017833#comment-13017833 ]
Hudson commented on HADOOP-7216:
--------------------------------
Integrated in Hadoop-Common-trunk #656 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/656/])
HADOOP-7216. Add FsCommand.runAll() with deprecated annotation for the transition of Command base class improvement. Contributed by Daryn Sharp
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7216-1.patch, hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017730#comment-13017730 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7216:
------------------------------------------------
+1 patch looks good.
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7216-1.patch, hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017310#comment-13017310 ]
Todd Lipcon commented on HADOOP-7216:
-------------------------------------
I'm not sure if this is the right spot, or if FsCommand.java's run method should have this as a body. Daryn, can you comment?
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017745#comment-13017745 ]
Hudson commented on HADOOP-7216:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #546 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/546/])
HADOOP-7216. Add FsCommand.runAll() with deprecated annotation for the transition of Command base class improvement. Contributed by Daryn Sharp
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7216-1.patch, hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017543#comment-13017543 ]
Daryn Sharp commented on HADOOP-7216:
-------------------------------------
Yes, I think it should be FsCommand along with a few other small tweaks. I can take over this bug if that's ok. I'm already in the process of testing a fix to retain complete compatibility.
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7216:
--------------------------------
Attachment: HADOOP-7216-1.patch
make a few changes for better backwards compat
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7216-1.patch, hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HADOOP-7216:
-----------------------------------
Status: Patch Available (was: Open)
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HADOOP-7216:
-----------------------------------
Attachment: hadoop-7216.0.txt
Trivial patch to add an implementation of the {{run}} method to the {{Count}} class. I manually verified that this fixes the test in HDFS.
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers reassigned HADOOP-7216:
--------------------------------------
Assignee: Daryn Sharp (was: Aaron T. Myers)
bq. I can take over this bug if that's OK.
Please do. Reassigning to you.
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017687#comment-13017687 ]
Hadoop QA commented on HADOOP-7216:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12475845/HADOOP-7216-1.patch
against trunk revision 1090039.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//console
This message is automatically generated.
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7216-1.patch, hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017692#comment-13017692 ]
Daryn Sharp commented on HADOOP-7216:
-------------------------------------
There are no tests, because it's designed to fix tests in hdfs.
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7216-1.patch, hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7216) HADOOP-7202 broke TestDFSShell in
HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7216:
-------------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I have committed this. Thanks Daryn!
> HADOOP-7202 broke TestDFSShell in HDFS
> --------------------------------------
>
> Key: HADOOP-7216
> URL: https://issues.apache.org/jira/browse/HADOOP-7216
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7216-1.patch, hadoop-7216.0.txt
>
>
> The commit of HADOOP-7202 now requires that classes that extend {{FsCommand}} implement the {{void run(PathData)}} method. The {{Count}} class was changed to extend {{FsCommand}}, but renamed the {{run}} method and did not provide a replacement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira