You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/24 09:08:03 UTC
[GitHub] [incubator-superset] villebro commented on issue #9360: Migrate
unique Heatmap controls
villebro commented on issue #9360: Migrate unique Heatmap controls
URL: https://github.com/apache/incubator-superset/pull/9360#issuecomment-603118350
@kristw @rusackas There seems to be a bunch of controls that are used in two plugins but aren't really general purpose plugins, e.g. `normalized`, `show_values`, `global_opacity` etc. I propose we move these into the most appropriate "parent" plugin, an import it from there where needed. For example, `normalized` should probably be defined in `Histogram`, and can then be imported and customized in `Heatmap`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org