[GitHub] [arrow] KarateSnowMachine commented on a diff in pull request #36191: GH-36189: [C++][Parquet] Parquet StreamReader::SkipRows() skips to incorrect place in multi-row-group files

["KarateSnowMachine (via GitHub)" <gi...@apache.org>]

KarateSnowMachine commented on code in PR #36191:
URL: https://github.com/apache/arrow/pull/36191#discussion_r1236946452


##########
cpp/src/parquet/stream_reader_test.cc:
##########
@@ -947,5 +947,77 @@ TEST_F(TestReadingDataFiles, ByteArrayDecimal) {
   EXPECT_EQ(i, 25);
 }
 
+class TestMultiRowGroupStreamReader : public ::testing::Test {
+ public:
+  TestMultiRowGroupStreamReader() { createTestFile(); }
+
+ protected:
+  const char* GetDataFile() const { return "stream_reader_multirowgroup_test.parquet"; }

Review Comment:
   I am happy to make that change but as this is my first contribution I'm not sure how to do this. This test fixture is simply a copy/paste of the existing `TestStreamReader` fixture above but with different initialization code.  Could you provide an example of how to do an in-memory file? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org