You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by bi...@apache.org on 2009/05/25 23:46:39 UTC

svn commit: r778519 - /commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/

Author: billbarker
Date: Mon May 25 21:46:38 2009
New Revision: 778519

URL: http://svn.apache.org/viewvc?rev=778519&view=rev
Log:
Serializable changes for linear.decomposition

Modified:
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/BiDiagonalTransformer.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecomposition.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecompositionImpl.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldDecompositionSolver.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecomposition.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecompositionImpl.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecomposition.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecompositionImpl.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecomposition.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecompositionImpl.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecomposition.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecompositionImpl.java
    commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/TriDiagonalTransformer.java

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/BiDiagonalTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/BiDiagonalTransformer.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/BiDiagonalTransformer.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/BiDiagonalTransformer.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.linear.MatrixUtils;
 import org.apache.commons.math.linear.RealMatrix;
 
@@ -37,10 +35,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-class BiDiagonalTransformer implements Serializable {
-
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = 8935390784125343332L;
+class BiDiagonalTransformer {
 
     /** Householder vectors. */
     private final double householderVectors[][];

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/CholeskyDecompositionImpl.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.MathRuntimeException;
 import org.apache.commons.math.linear.InvalidMatrixException;
 import org.apache.commons.math.linear.MatrixUtils;
@@ -39,12 +37,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-public class CholeskyDecompositionImpl implements CholeskyDecomposition, Serializable {
-    // TODO: Add Serializable documentation
-    // TODO: Check Serializable implementation
-
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = -2036131698031167221L;
+public class CholeskyDecompositionImpl implements CholeskyDecomposition {
 
     /** Default threshold above which off-diagonal elements are considered too different
      * and matrix not symmetric. */
@@ -198,13 +191,8 @@
     }
 
     /** Specialized solver. */
-    private static class Solver implements DecompositionSolver, Serializable {
-        // TODO: Add Serializable documentation
-        // TODO: Check Serializable implementation
-
-        /** Serializable version identifier. */
-        private static final long serialVersionUID = -7288829864732555901L;
-
+    private static class Solver implements DecompositionSolver {
+    
         /** Row-oriented storage for L<sup>T</sup> matrix data. */
         private final double[][] lTData;
 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecomposition.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecomposition.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecomposition.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecomposition.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.linear.RealMatrix;
 import org.apache.commons.math.linear.RealVector;
 
@@ -45,7 +43,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-public interface EigenDecomposition extends Serializable {
+public interface EigenDecomposition {
 
     /**
      * Returns the matrix V of the decomposition. 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecompositionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecompositionImpl.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecompositionImpl.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/EigenDecompositionImpl.java Mon May 25 21:46:38 2009
@@ -17,7 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -63,9 +62,6 @@
  */
 public class EigenDecompositionImpl implements EigenDecomposition {
 
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = 1625101476333719659L;
-
     /** Tolerance. */
     private static final double TOLERANCE = 100 * MathUtils.EPSILON;
 
@@ -366,13 +362,8 @@
     }
 
     /** Specialized solver. */
-    private static class Solver implements DecompositionSolver, Serializable {
-        // TODO: Add Serializable documentation
-        // TODO: Check Serializable implementation
-
-        /** Serializable version identifier. */
-        private static final long serialVersionUID = -8965845906036558410L;
-
+    private static class Solver implements DecompositionSolver {
+    
         /** Real part of the realEigenvalues. */
         private double[] realEigenvalues;
 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldDecompositionSolver.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldDecompositionSolver.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldDecompositionSolver.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldDecompositionSolver.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.FieldElement;
 import org.apache.commons.math.linear.FieldMatrix;
 import org.apache.commons.math.linear.FieldVector;
@@ -40,7 +38,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-public interface FieldDecompositionSolver<T extends FieldElement<T>> extends Serializable {
+public interface FieldDecompositionSolver<T extends FieldElement<T>> {
 
     /** Solve the linear equation A &times; X = B for matrices A.
      * <p>The A matrix is implicit, it is provided by the underlying

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecomposition.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecomposition.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecomposition.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecomposition.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.FieldElement;
 import org.apache.commons.math.linear.FieldMatrix;
 
@@ -48,7 +46,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-public interface FieldLUDecomposition<T extends FieldElement<T>> extends Serializable {
+public interface FieldLUDecomposition<T extends FieldElement<T>> {
 
     /**
      * Returns the matrix L of the decomposition. 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecompositionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecompositionImpl.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecompositionImpl.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/FieldLUDecompositionImpl.java Mon May 25 21:46:38 2009
@@ -44,9 +44,6 @@
  */
 public class FieldLUDecompositionImpl<T extends FieldElement<T>> implements FieldLUDecomposition<T> {
 
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = 1954692554563387537L;
-
     /** Field to which the elements belong. */
     private final Field<T> field;
 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecomposition.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecomposition.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecomposition.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecomposition.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.linear.RealMatrix;
 
 /**
@@ -46,7 +44,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-public interface LUDecomposition extends Serializable {
+public interface LUDecomposition {
 
     /**
      * Returns the matrix L of the decomposition. 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecompositionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecompositionImpl.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecompositionImpl.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/LUDecompositionImpl.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.MathRuntimeException;
 import org.apache.commons.math.linear.InvalidMatrixException;
 import org.apache.commons.math.linear.MatrixUtils;
@@ -41,9 +39,6 @@
  */
 public class LUDecompositionImpl implements LUDecomposition {
 
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = 1954692554563387537L;
-
     /** Entries of LU decomposition. */
     private double lu[][];
 
@@ -238,13 +233,8 @@
     }
 
     /** Specialized solver. */
-    private static class Solver implements DecompositionSolver, Serializable {
-        // TODO: Add Serializable documentation
-        // TODO: Check Serializable implementation
-
-        /** Serializable version identifier. */
-        private static final long serialVersionUID = -6353105415121373022L;
-
+    private static class Solver implements DecompositionSolver {
+    
         /** Entries of LU decomposition. */
         private final double lu[][];
 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecomposition.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecomposition.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecomposition.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecomposition.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.linear.RealMatrix;
 
 /**
@@ -39,7 +37,7 @@
  * @version $Revision$ $Date$
  * @since 1.2
  */
-public interface QRDecomposition extends Serializable {
+public interface QRDecomposition {
 
     /**
      * Returns the matrix R of the decomposition. 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecompositionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecompositionImpl.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecompositionImpl.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/QRDecompositionImpl.java Mon May 25 21:46:38 2009
@@ -17,7 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
 import java.util.Arrays;
 
 import org.apache.commons.math.MathRuntimeException;
@@ -47,9 +46,6 @@
  */
 public class QRDecompositionImpl implements QRDecomposition {
 
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = -2036131698031167221L;
-
     /**
      * A packed TRANSPOSED representation of the QR decomposition.
      * <p>The elements BELOW the diagonal are the elements of the UPPER triangular
@@ -257,13 +253,8 @@
     }
 
     /** Specialized solver. */
-    private static class Solver implements DecompositionSolver, Serializable {
-        // TODO: Add Serializable documentation
-        // TODO: Check Serializable implementation
-
-        /** Serializable version identifier. */
-        private static final long serialVersionUID = -6353105415121373022L;
-
+    private static class Solver implements DecompositionSolver {
+    
         /**
          * A packed TRANSPOSED representation of the QR decomposition.
          * <p>The elements BELOW the diagonal are the elements of the UPPER triangular

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecomposition.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecomposition.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecomposition.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecomposition.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.linear.RealMatrix;
 
 
@@ -49,7 +47,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-public interface SingularValueDecomposition extends Serializable {
+public interface SingularValueDecomposition {
 
     /**
      * Returns the matrix U of the decomposition. 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecompositionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecompositionImpl.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecompositionImpl.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/SingularValueDecompositionImpl.java Mon May 25 21:46:38 2009
@@ -17,8 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
-
 import org.apache.commons.math.ConvergenceException;
 import org.apache.commons.math.MathRuntimeException;
 import org.apache.commons.math.linear.InvalidMatrixException;
@@ -40,9 +38,6 @@
  */
 public class SingularValueDecompositionImpl implements SingularValueDecomposition {
 
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = -3532767302235568872L;
-
     /** Number of rows of the initial matrix. */
     private int m;
 
@@ -299,13 +294,8 @@
     }
 
     /** Specialized solver. */
-    private static class Solver implements DecompositionSolver, Serializable {
-        // TODO: Add Serializable documentation
-        // TODO: Check Serializable implementation
-
-        /** Serializable version identifier. */
-        private static final long serialVersionUID = -1959408026708904378L;
-
+    private static class Solver implements DecompositionSolver {
+        
         /** Singular values. */
         private final double[] singularValues;
 

Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/TriDiagonalTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/TriDiagonalTransformer.java?rev=778519&r1=778518&r2=778519&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/TriDiagonalTransformer.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/decomposition/TriDiagonalTransformer.java Mon May 25 21:46:38 2009
@@ -17,7 +17,6 @@
 
 package org.apache.commons.math.linear.decomposition;
 
-import java.io.Serializable;
 import java.util.Arrays;
 
 import org.apache.commons.math.linear.InvalidMatrixException;
@@ -39,10 +38,7 @@
  * @version $Revision$ $Date$
  * @since 2.0
  */
-class TriDiagonalTransformer implements Serializable {
-
-    /** Serializable version identifier. */
-    private static final long serialVersionUID = 8935390784125343332L;
+class TriDiagonalTransformer {
 
     /** Householder vectors. */
     private final double householderVectors[][];