You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/10/11 01:19:03 UTC
[kudu-CR] [master] --location mapping cmd is experimental
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11652
Change subject: [master] --location_mapping_cmd is experimental
......................................................................
[master] --location_mapping_cmd is experimental
Re-tagged --location_mapping_cmd: evolving --> experimental.
Not all pieces of the location-awareness is there yet, so let's
mark the location mapping flag as 'experimental' instead of 'evolving'.
The rationale is simple: the feature is not yet code-complete and
there might be some usability issues if using the location awareness
provisions at this point. E.g., location-unaware rebalancer would
violate the placement policies if run against a cluster with locations
defined, etc.
Change-Id: I783f07ff070d608deacfd6dd055fede80795b3ee
---
M src/kudu/master/ts_descriptor.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/11652/1
--
To view, visit http://gerrit.cloudera.org:8080/11652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I783f07ff070d608deacfd6dd055fede80795b3ee
Gerrit-Change-Number: 11652
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master] --location mapping cmd is experimental
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11652 )
Change subject: [master] --location_mapping_cmd is experimental
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I783f07ff070d608deacfd6dd055fede80795b3ee
Gerrit-Change-Number: 11652
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 01:53:59 +0000
Gerrit-HasComments: No
[kudu-CR] [master] --location mapping cmd is experimental
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11652 )
Change subject: [master] --location_mapping_cmd is experimental
......................................................................
[master] --location_mapping_cmd is experimental
Re-tagged --location_mapping_cmd: evolving --> experimental.
Not all pieces of the location-awareness is there yet, so let's
mark the location mapping flag as 'experimental' instead of 'evolving'.
The rationale is simple: the feature is not yet code-complete and
there might be some usability issues if using the location awareness
provisions at this point. E.g., location-unaware rebalancer would
violate the placement policies if run against a cluster with locations
defined, etc.
Change-Id: I783f07ff070d608deacfd6dd055fede80795b3ee
Reviewed-on: http://gerrit.cloudera.org:8080/11652
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/master/ts_descriptor.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I783f07ff070d608deacfd6dd055fede80795b3ee
Gerrit-Change-Number: 11652
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>