[jira] [Commented] (PHOENIX-2902) Adjust PhoenixDatabaseMetadata#getSchemas query if namespaces are enabled

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362111#comment-15362111 ] 

Hadoop QA commented on PHOENIX-2902:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12816134/PHOENIX-2902_v1.patch
  against master branch at commit 5570a73ffd5e73ca6afef302d8f025665f40c9db.
  ATTACHMENT ID: 12816134

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 34 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryDatabaseMetaDataWithNamespaceEnabledIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/425//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/425//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/425//console

This message is automatically generated.

> Adjust PhoenixDatabaseMetadata#getSchemas query if namespaces are enabled
> -------------------------------------------------------------------------
>
>                 Key: PHOENIX-2902
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2902
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: James Taylor
>            Assignee: Ankit Singhal
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2902.patch, PHOENIX-2902_v1.patch
>
>
> The call to PhoenixDatabaseMetaData.getSchemas() currently queries the SYSTEM.CATALOG table to find distinct schema names. If namespaces are enabled, we should likely adjust the query accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)