You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/03/11 04:44:21 UTC
Review Request 19008: Moved LevelDBStorageProcess and
ZooKeeperStorageProcess out of the header files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19008/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
See above, there was no need in this case to expose the Process implementation for these.
I did this to keep consistency with the new InMemoryStorage layer I am adding.
Diffs
-----
src/java/jni/org_apache_mesos_state_AbstractState.cpp 154bbc6966a6d3a0f9aa942edcfb8edccd23cea3
src/state/leveldb.hpp 14a94ccaceb7f60fea647a2cbda1836af93af3c2
src/state/leveldb.cpp be0df0cf87e54254e067fc308e225e7a304d2086
src/state/zookeeper.hpp cfc883191a07b71bdc301f85063578957846bba7
src/state/zookeeper.cpp 09b63d44e9349cab2d73659c939de3d8e96fbcc5
Diff: https://reviews.apache.org/r/19008/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 19008: Moved LevelDBStorageProcess and
ZooKeeperStorageProcess out of the header files.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19008/#review36796
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On March 10, 2014, 8:44 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19008/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 8:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above, there was no need in this case to expose the Process implementation for these.
>
> I did this to keep consistency with the new InMemoryStorage layer I am adding.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 154bbc6966a6d3a0f9aa942edcfb8edccd23cea3
> src/state/leveldb.hpp 14a94ccaceb7f60fea647a2cbda1836af93af3c2
> src/state/leveldb.cpp be0df0cf87e54254e067fc308e225e7a304d2086
> src/state/zookeeper.hpp cfc883191a07b71bdc301f85063578957846bba7
> src/state/zookeeper.cpp 09b63d44e9349cab2d73659c939de3d8e96fbcc5
>
> Diff: https://reviews.apache.org/r/19008/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 19008: Moved LevelDBStorageProcess and
ZooKeeperStorageProcess out of the header files.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19008/#review36851
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 11, 2014, 3:44 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19008/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 3:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above, there was no need in this case to expose the Process implementation for these.
>
> I did this to keep consistency with the new InMemoryStorage layer I am adding.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 154bbc6966a6d3a0f9aa942edcfb8edccd23cea3
> src/state/leveldb.hpp 14a94ccaceb7f60fea647a2cbda1836af93af3c2
> src/state/leveldb.cpp be0df0cf87e54254e067fc308e225e7a304d2086
> src/state/zookeeper.hpp cfc883191a07b71bdc301f85063578957846bba7
> src/state/zookeeper.cpp 09b63d44e9349cab2d73659c939de3d8e96fbcc5
>
> Diff: https://reviews.apache.org/r/19008/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 19008: Moved LevelDBStorageProcess and
ZooKeeperStorageProcess out of the header files.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19008/#review36756
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19008]
All tests passed.
- Mesos ReviewBot
On March 11, 2014, 3:44 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19008/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 3:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above, there was no need in this case to expose the Process implementation for these.
>
> I did this to keep consistency with the new InMemoryStorage layer I am adding.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 154bbc6966a6d3a0f9aa942edcfb8edccd23cea3
> src/state/leveldb.hpp 14a94ccaceb7f60fea647a2cbda1836af93af3c2
> src/state/leveldb.cpp be0df0cf87e54254e067fc308e225e7a304d2086
> src/state/zookeeper.hpp cfc883191a07b71bdc301f85063578957846bba7
> src/state/zookeeper.cpp 09b63d44e9349cab2d73659c939de3d8e96fbcc5
>
> Diff: https://reviews.apache.org/r/19008/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>