[jira] Updated: (THRIFT-916) gcc warnings in c++ header files

["Roger Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier updated THRIFT-916:
-------------------------------

    Attachment: THRIFT-916_Wall_pedantic__noerrors.patch

With this patches [^THRIFT-916_Wall_pedantic__noerrors.patch] we have no errors on compiling with CXXFLAGS="-Wall -Wextra -pedantic" on GNU/Linux Debian Lenny

could someone please verify?

> gcc warnings in c++ header files
> --------------------------------
>
>                 Key: THRIFT-916
>                 URL: https://issues.apache.org/jira/browse/THRIFT-916
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.4
>            Reporter: Piotr Bartosiewicz
>         Attachments: THRIFT-916_Wall_pedantic__noerrors.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall -Wextra -pedantic" options. 
> Currently only with -Wall thrift has no warnings. 
> Other options worth considering (but require more work) are -Wconversion -Wold-style-cast
> So the task is to improve the thrift headers. 
> I suggest also update all the thrift makefiles so the thrift sources an tests will indicate the faulty code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.