You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2006/03/03 17:23:40 UTC

Re: svn commit: r382752 - /apr/apr/trunk/build/MakeEtags

On 3/3/06, maxb@apache.org <ma...@apache.org> wrote:
> Author: maxb
> Date: Fri Mar  3 02:26:58 2006
> New Revision: 382752
>
> URL: http://svn.apache.org/viewcvs?rev=382752&view=rev
> Log:
> * build/MakeEtags: Convert to be useful for APR and APR-util as well as HTTPD.
>   Do not hardcode a specific path to etags, use ETAGS envvar, or search PATH.
>   Update URL to "Exuberant ctags" project home.
>
> PR: 22615
>
> Modified:
>     apr/apr/trunk/build/MakeEtags
>
> Modified: apr/apr/trunk/build/MakeEtags
> URL: http://svn.apache.org/viewcvs/apr/apr/trunk/build/MakeEtags?rev=382752&r1=382751&r2=382752&view=diff
> ==============================================================================
> --- apr/apr/trunk/build/MakeEtags (original)
> +++ apr/apr/trunk/build/MakeEtags Fri Mar  3 02:26:58 2006
> @@ -12,22 +12,24 @@
>  # tag-table-alist with an entry to assure it finds the single ./TAGS
>  # file from the many source directories.  Something along these lines:
>  # (setq tag-table-alist
> -#      '(("/home/me/work/httpd-2.0/"
> -#         . "/home/me/work/httpd-2.0/")
> +#      '(("/home/me/work/apr-x.y/" . "/home/me/work/apr-x.y/")
> +#        ("/home/me/work/apr-util-x.y/" . "/home/me/work/apr-util-x.y/")
> +#        ("/home/me/work/httpd-x.y/" . "/home/me/work/httpd-x.y/")
>  #       ))
>
>  # This requires a special version of etags, i.e. the
>  # one called "Exuberant ctags" available at:
> -#    http://fly.hiwaay.net/~darren/ctags/
> +#    http://ctags.sourceforge.net/
>  # Once that is setup you'll need to point to the
>  # executable here:
>
> -etags=~/local/bin/etags
> +etags=${ETAGS-etags}

Isn't that supposed to be ${ETAGS:-etags} ?  You seem to have dropped the colon.

-garrett

Re: svn commit: r382752 - /apr/apr/trunk/build/MakeEtags

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 3/3/06, Max Bowsher <ma...@ukf.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Garrett Rooney wrote:
> >> -etags=~/local/bin/etags
> >> +etags=${ETAGS-etags}
> >
> > Isn't that supposed to be ${ETAGS:-etags} ?
> > You seem to have dropped the colon.
>
> Both of these are valid in modern-ish Bourne-type shells:
>
> ${VAR-fallback_if_unset}
> ${VAR:-fallback_if_unset_or_set_to_null_string}
>
> The first form is shorter to type, and the autoconf docs say that it is
> fractionally more portable.

Ahh, ok.  I had only ever seen the version with the colon (In APR's
buildconf script, FWIW).

-garrett

Re: svn commit: r382752 - /apr/apr/trunk/build/MakeEtags

Posted by Max Bowsher <ma...@ukf.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Garrett Rooney wrote:
>> -etags=~/local/bin/etags
>> +etags=${ETAGS-etags}
> 
> Isn't that supposed to be ${ETAGS:-etags} ?
> You seem to have dropped the colon.

Both of these are valid in modern-ish Bourne-type shells:

${VAR-fallback_if_unset}
${VAR:-fallback_if_unset_or_set_to_null_string}

The first form is shorter to type, and the autoconf docs say that it is
fractionally more portable.


Max.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFECII0fFNSmcDyxYARAkyKAKCfJ1J3NMHNSJZhfBh6b8qmyz9FuwCguIr/
IUIrOAOZitsaohE7moTBcqU=
=frIR
-----END PGP SIGNATURE-----