You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Jake Maes (JIRA)" <ji...@apache.org> on 2016/05/10 17:37:13 UTC

[jira] [Commented] (SAMZA-852) Better logging when system can not be created

    [ https://issues.apache.org/jira/browse/SAMZA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278524#comment-15278524 ] 

Jake Maes commented on SAMZA-852:
---------------------------------

Hey [~vchekan], 

Thanks for this patch. It turns out if we had applied this earlier, we would have prevented the same issue Tim reported in the dev mailing list today. He was getting an exception instantiating the elastic search producer but the exception wasn't getting printed by default. 

I'd like to expedite this patch, but need a couple things from you:
1. Can you update the patch so that it logs errors for system consumers as well? The change is identical and about 17 lines earlier in the same file. 
2. Post a review board review for this patch. For help doing this see:
http://samza.apache.org/contribute/rules.html
and 
https://cwiki.apache.org/confluence/display/SAMZA/Contributor%27s+Corner

If I don't hear from you in the next day or 2, I'll assume you don't have the cycles and I'll take this task. 

Thanks!

> Better logging when system can not be created
> ---------------------------------------------
>
>                 Key: SAMZA-852
>                 URL: https://issues.apache.org/jira/browse/SAMZA-852
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Vadim Chekan
>            Priority: Minor
>             Fix For: 0.10.1
>
>         Attachments: 0001-Inability-to-create-configured-producer-should-be-lo.patch
>
>
> Inability to create configured producer should be logged as error. If not, it leads to unneeded investigation "why does it say system X can not be found, here it is!".
> Also, do not drop the original exception, it makes troubleshooting more difficult.
> My pull request: https://github.com/apache/samza/pull/8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)