You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/03/02 14:53:34 UTC
[GitHub] [incubator-daffodil] gezapeti opened a new pull request #329: Add
noPretty to disable pretty print for XML and JSON formats
gezapeti opened a new pull request #329: Add noPretty to disable pretty print for XML and JSON formats
URL: https://github.com/apache/incubator-daffodil/pull/329
DAFFODIL-2234
I'm not sure this is the correct way to implement this option. I couldn't figure out a way to place it in a subcommand, so I went with a general command there. No tests yet, I wanted to clarify if the path is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] stevedlawrence commented on issue #329: WIP:
Add noPretty to disable pretty print for XML and JSON formats
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on issue #329: WIP: Add noPretty to disable pretty print for XML and JSON formats
URL: https://github.com/apache/incubator-daffodil/pull/329#issuecomment-611003256
I think we at the least need to move the option out of the global options and into the parse options. Also, keep in mind that although it's a small, it could be considered part of the CLI "API", so changing things later potentially has issues with backwards compatibilty.
But as long as this is moved out of the global options I'm fine with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] gezapeti commented on issue #329: Add noPretty
to disable pretty print for XML and JSON formats
Posted by GitBox <gi...@apache.org>.
gezapeti commented on issue #329: Add noPretty to disable pretty print for XML and JSON formats
URL: https://github.com/apache/incubator-daffodil/pull/329#issuecomment-593462160
I've been looking around and maybe I should start with DAFFODIL-1958 and that would make this one easier as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] stevedlawrence commented on issue #329: Add
noPretty to disable pretty print for XML and JSON formats
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on issue #329: Add noPretty to disable pretty print for XML and JSON formats
URL: https://github.com/apache/incubator-daffodil/pull/329#issuecomment-593463913
Potentially. DAFFODIL-1958 would be a really nice bug to resolve. The entire CLI is basically one giant function. Cleaning up the Scallop config is the first step in making that main function easier to update and manage. Definiately a worthy bug to work on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] gezapeti commented on issue #329: WIP: Add
noPretty to disable pretty print for XML and JSON formats
Posted by GitBox <gi...@apache.org>.
gezapeti commented on issue #329: WIP: Add noPretty to disable pretty print for XML and JSON formats
URL: https://github.com/apache/incubator-daffodil/pull/329#issuecomment-612205406
I've stopped working on this one and started with DAFFODIL-1958, but I find it hard to wrap my head around the logic of scallop - and working from home eats up all the free cycles I could spend on that. I'm fine with moving the option to parsing option and we can change things under the hood if the option name itself is good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services