You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2017/01/06 20:50:19 UTC
Review Request 55277: AMBARI-19392. Status command executor may use
obsolete settings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55277/
-----------------------------------------------------------
Review request for Ambari.
Repository: ambari
Description
-------
Spawn status command executor after registration to ensure that the child process which runs status command executor gets agent config which is finalized after agent registers with the server.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py d70b344
ambari-agent/src/main/python/ambari_agent/Controller.py 56b1992
Diff: https://reviews.apache.org/r/55277/diff/
Testing
-------
Manual testing (verify that `agent.auto.cache.update=false` setting from server is applied in status command executor child process).
ambari-agent unit tests:
----------------------------------------------------------------------
Ran 452 tests in 101.627s
OK
Thanks,
Sebastian Toader
Re: Review Request 55277: AMBARI-19392. Status command executor may
use obsolete settings
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55277/#review160768
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On Jan. 6, 2017, 9:54 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55277/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 9:54 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-19392
> https://issues.apache.org/jira/browse/AMBARI-19392
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Spawn status command executor after registration to ensure that the child process which runs status command executor gets agent config which is finalized after agent registers with the server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py d70b344
> ambari-agent/src/main/python/ambari_agent/Controller.py 56b1992
>
> Diff: https://reviews.apache.org/r/55277/diff/
>
>
> Testing
> -------
>
> Manual testing (verify that `agent.auto.cache.update=false` setting from server is applied in status command executor child process).
>
> ambari-agent unit tests:
> ----------------------------------------------------------------------
> Ran 452 tests in 101.627s
>
> OK
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 55277: AMBARI-19392. Status command executor may
use obsolete settings
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55277/#review160762
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Jan. 6, 2017, 8:54 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55277/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 8:54 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-19392
> https://issues.apache.org/jira/browse/AMBARI-19392
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Spawn status command executor after registration to ensure that the child process which runs status command executor gets agent config which is finalized after agent registers with the server.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py d70b344
> ambari-agent/src/main/python/ambari_agent/Controller.py 56b1992
>
> Diff: https://reviews.apache.org/r/55277/diff/
>
>
> Testing
> -------
>
> Manual testing (verify that `agent.auto.cache.update=false` setting from server is applied in status command executor child process).
>
> ambari-agent unit tests:
> ----------------------------------------------------------------------
> Ran 452 tests in 101.627s
>
> OK
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 55277: AMBARI-19392. Status command executor may
use obsolete settings
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55277/
-----------------------------------------------------------
(Updated Jan. 6, 2017, 9:54 p.m.)
Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-19392
https://issues.apache.org/jira/browse/AMBARI-19392
Repository: ambari
Description
-------
Spawn status command executor after registration to ensure that the child process which runs status command executor gets agent config which is finalized after agent registers with the server.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py d70b344
ambari-agent/src/main/python/ambari_agent/Controller.py 56b1992
Diff: https://reviews.apache.org/r/55277/diff/
Testing
-------
Manual testing (verify that `agent.auto.cache.update=false` setting from server is applied in status command executor child process).
ambari-agent unit tests:
----------------------------------------------------------------------
Ran 452 tests in 101.627s
OK
Thanks,
Sebastian Toader