You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/27 22:14:36 UTC
Review Request 58819: Clarified the comment about Container.directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58819/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
Diff: https://reviews.apache.org/r/58819/diff/1/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 58819: Clarified the comment about
Container.directory.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58819/#review173377
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58819/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
>
>
> Diff: https://reviews.apache.org/r/58819/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 58819: Clarified the comment about
Container.directory.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58819/
-----------------------------------------------------------
(Updated May 9, 2017, 2:31 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Rebased. NNTR.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
Diff: https://reviews.apache.org/r/58819/diff/4/
Changes: https://reviews.apache.org/r/58819/diff/3-4/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 58819: Clarified the comment about
Container.directory.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58819/
-----------------------------------------------------------
(Updated May 3, 2017, 4:45 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Rebased, NNTR.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
Diff: https://reviews.apache.org/r/58819/diff/3/
Changes: https://reviews.apache.org/r/58819/diff/2-3/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 58819: Clarified the comment about
Container.directory.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58819/
-----------------------------------------------------------
(Updated April 28, 2017, 4:14 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
Diff: https://reviews.apache.org/r/58819/diff/2/
Changes: https://reviews.apache.org/r/58819/diff/1-2/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 58819: Clarified the comment about
Container.directory.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58819/#review173270
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/containerizer.hpp
Lines 325 (patched)
<https://reviews.apache.org/r/58819/#comment246311>
host mount namespace.
- Jie Yu
On April 27, 2017, 10:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58819/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 10:14 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
>
>
> Diff: https://reviews.apache.org/r/58819/diff/1/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>