You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/29 08:56:18 UTC
[GitHub] [druid] leventov opened a new issue #9106: Unbalanced
synchronization of ResponseContext.REGISTERED_KEYS
leventov opened a new issue #9106: Unbalanced synchronization of ResponseContext.REGISTERED_KEYS
URL: https://github.com/apache/druid/issues/9106
To make it really thread-safe:
1. `keyOf()` and `getAllRegisteredKeys()` should be made synchronized;
2. `getAllRegisteredKeys()` should return a defensive copy: `new TreeMap<>(REGISTERED_KEYS).values()`
Relevant concurrency checklist items: https://github.com/code-review-checklists/java-concurrency#unsafe-concurrent-point-read, https://github.com/code-review-checklists/java-concurrency#unsafe-concurrent-iteration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] esevastyanov commented on issue #9106: Unbalanced
synchronization of ResponseContext.REGISTERED_KEYS
Posted by GitBox <gi...@apache.org>.
esevastyanov commented on issue #9106: Unbalanced synchronization of ResponseContext.REGISTERED_KEYS
URL: https://github.com/apache/druid/issues/9106#issuecomment-570170550
Agreed. There is no guarantee that `registerKey` would be called only from class static blocks as originally designed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org