You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/10 02:25:00 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2272: sched: pthread: Fix pthread_join() for SMP

masayuki2009 opened a new pull request #2272:
URL: https://github.com/apache/incubator-nuttx/pull/2272


   ## Summary
   
   - I noticed 'pthread_rwlock test' in ostest sometimes stops
   - This issue happened with spresense:wifi_smp (NCPUS=4) and sim:smp
   - Finally, I found an issue in pthread_join()
   - In pthread_join(), sched_lock() is used to avoid pre-emption
   - However, this is not enough for SMP
   - Because another CPU would continue the pthread and exit sequences
   - So we need to protect it with a critical section
   
   ## Impact
   
   - Affect SMP only
   
   ## Testing
   
   - Tested with ostest with the following configurations
   - spresnese:smp
   - spresense:wifi_smp (NCPUS=2, NCPUS=4)
   - sabre-6quad:smp (QEMU)
   - esp32-core:smp (QEMU)
   - maix-bit:smp (QEMU)
   - sim:smp
   - lc823450-xgevk:rndis
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2272: sched: pthread: Fix pthread_join() for SMP

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2272:
URL: https://github.com/apache/incubator-nuttx/pull/2272


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2272: sched: pthread: Fix pthread_join() for SMP

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2272:
URL: https://github.com/apache/incubator-nuttx/pull/2272#issuecomment-724408262


   See https://github.com/apache/incubator-nuttx/pull/2109 as well
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org