You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "iwasakims (via GitHub)" <gi...@apache.org> on 2024/05/01 04:27:02 UTC
[PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
iwasakims opened a new pull request, #1266:
URL: https://github.com/apache/bigtop/pull/1266
https://issues.apache.org/jira/browse/BIGTOP-4102
```
[91m[1;31mError: Evaluation Error: Unknown variable: '::operatingsystem'. (file: /etc/puppet/code/modules/bigtop_toolchain/manifests/jdk11.pp, line: 17, column: 8) on node bigtop-slave-arm5.novalocal[0m
[0mThe command '/bin/sh -c if [ -f ~/.bash_profile ]; then . ~/.bash_profile; fi && dnf clean all && dnf updateinfo && puppet apply -e "include bigtop_toolchain::installer" || if [ $? -ne 2 ]; then exit 1; fi' returned a non-zero code: 1
```
[Legacy facts are disabled by default in Puppet 8](https://www.puppet.com/docs/pe/2023.5/osp/upgrading-from-puppet7-to-puppet8.html#upgrading-from-puppet7-to-puppet8-legacy-facts-deprecation). include_legacy_facts=true in puppet.conf will re-enable it.
This PR is quick fix only targeting fedora-38. I filed [BIGTOP-4103](https://issues.apache.org/jira/browse/BIGTOP-4103) as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "yoda-mon (via GitHub)" <gi...@apache.org>.
yoda-mon merged PR #1266:
URL: https://github.com/apache/bigtop/pull/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2100446201
puppet 8 packaged by fedora-38 is coupled with hiera 3. I guess the error is caused by just variable lookup settings.
```
[root@495d41ec7cd8 /]# rpm -q hiera
hiera-3.11.0-2.fc38.noarch
[root@495d41ec7cd8 /]# rpm -q --whatrequires hiera
puppet-8.3.1-1.fc38.noarc
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2104310372
@yoda-mon Could you take a look again? This issue blocks release of Bigtop 3.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2092494273
@yoda-mon The images on Docker Hub will be updated by running Jenkins jobs. I will run them after merging this PR.
* https://ci.bigtop.apache.org/job/Docker-Puppet-Trunk/
* https://ci.bigtop.apache.org/job/Docker-Toolchain-Trunk/
If the manifest of bigtop-deploy contains code incompatible with Puppet 8, it should be fixed in follow-up JIRAs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2104309475
The cause of the error turned out to be bug of the manifest rather than Puppet version. smoke-tests of Hadoop passed on both fedora-38 and centos-7 with the updated manifest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2104058359
The current manifest [tries to conditionaly switch hiera file](https://github.com/apache/bigtop/blob/3808ba7d1b8d6c2504c08ed9079a9d5673ae83de/bigtop-deploy/puppet/hiera.yaml#L6) based on [the variable in class](https://github.com/apache/bigtop/blob/3808ba7d1b8d6c2504c08ed9079a9d5673ae83de/bigtop-deploy/puppet/manifests/cluster.pp#L158-L163). We can not assume that the class local variable is visible. We should switch ha/non-ha by explicit declaration in site.yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "yoda-mon (via GitHub)" <gi...@apache.org>.
yoda-mon commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2090956848
@iwasakims It seems work well but I have one concern about the Puppet version.
After applying this patch
```sh
./gradlew -Pprefix=trunk -POS=fedora-38 bigtop-puppet
./gradlew -Pprefix=trunk -POS=fedora-38 bigtop-slaves
```
Both builds succeeded. but
```
docker run -it --rm bigtop/puppet:trunk-fedora-38-aarch64 puppet --version
```
showed `8.3.1`. The images that uploads to dockerhub shows `7.27.0` today, and the difference might affect the smoke tests.
This may not be caused by this PR, but we might have to fix the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2099893700
Actually [deprecation of Hiera 3](https://www.puppet.com/docs/puppet/8/upgrading-from-puppet7-to-puppet8.html#upgrading-from-puppet7-to-puppet8-heira-3-deprecation) affects bigtop-deploy. I will add commit to fix this.
```
Error: Undefined variable 'hadoop_hiera_ha_path' (file: /etc/puppet/hiera.yaml, line: 8) on node 1ac306408ff6.bigtop.apache.org
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "yoda-mon (via GitHub)" <gi...@apache.org>.
yoda-mon commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2105662465
@iwasakims (Sorry for the late, I was on vacation)
Thank you for the information, I understood the situations related to the deprecation of Hiera 3.
On that case, the build itself was suceeded so let's merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4102. Fix failure of toolchain manifest on Fedora 38 due to unresolved facter variable [bigtop]
Posted by "iwasakims (via GitHub)" <gi...@apache.org>.
iwasakims commented on PR #1266:
URL: https://github.com/apache/bigtop/pull/1266#issuecomment-2106588225
Thanks, @yoda-mon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org