[GitHub] [hbase] NihalJain commented on pull request #5346: HBASE-27991 fixing ClassCastException in multithread client run

["NihalJain (via GitHub)" <gi...@apache.org>]

NihalJain commented on PR #5346:
URL: https://github.com/apache/hbase/pull/5346#issuecomment-1709880884

   > I suspect https://issues.apache.org/jira/browse/HBASE-22244 / https://github.com/apache/hbase/pull/155 might have broken compatibility on what can be passed to ExecutorService as the failure of this example client shows that an old client code which was passing ForkJoinPool no longer works and requires a ThreadPoolExecutor only.
   
   > I have been able to write a UT to confirm this. Raised https://issues.apache.org/jira/browse/HBASE-28035, raised a UT PR to demonstrate same at #5365
   
   Since we have a JIRA for the issue which cause this class to fail, I am good with this change to go in as is. We can look at the issue which introduced this bug as part of HBASE-28035.
   
   +1 to this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org