[GitHub] markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip

[gi...@git.apache.org]

markusthoemmes commented on a change in pull request #2857: Emit metrics via kamon - wip
URL: https://github.com/apache/incubator-openwhisk/pull/2857#discussion_r144825903
 
 

 ##########
 File path: ansible/group_vars/all
 ##########
 @@ -105,7 +105,11 @@ limits:
 controller:
   basePort: 10001
   heap: "{{ controller_heap | default('2g') }}"
-  arguments: "{{ controller_arguments | default('') }}"
+  arguments: "{% if metrics.kamon == true %} 
+                {{ controller_arguments + ' -Dkamon.statsd.hostname=' + metrics_kamon_statsd_host + ' -Dkamon.statsd.port=' + metrics_kamon_statsd_port | default('') }} 
+              {% else %} 
+                {{ controller_arguments | default('') }} 
+              {% endif %}"  
 
 Review comment:
   Let's fix these bits, I have an ENV->JVM System property adapter script stashed in another PR. I'll finish that off, then we can clean these up (We need system props for SPIs for example anyway).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services