[GitHub] [hbase] saintstack commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312747165
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
 ##########
 @@ -429,7 +429,9 @@ private void cacheBlockWithWaitInternal(BlockCacheKey cacheKey, Cacheable cached
     if (!cacheEnabled) {
       return;
     }
-    LOG.trace("Caching key={}, item={}", cacheKey, cachedItem);
+    if (LOG.isTraceEnabled()) {
 
 Review comment:
   Don't need this if LOG.isTraceEnabled when using this logging form with the '{}' (Internally it does this test).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services