[GitHub] [tvm] huanmei9 commented on a diff in pull request #12315: [TOPI][OP]change float multiplication of resize op to integer division

[GitBox <gi...@apache.org>]

huanmei9 commented on code in PR #12315:
URL: https://github.com/apache/tvm/pull/12315#discussion_r941078556


##########
tests/python/topi/python/test_topi_upsampling.py:
##########
@@ -101,6 +101,38 @@ def check_target(target, dev):
         check_target(target, dev)
 
 
+@tvm.testing.uses_gpu

Review Comment:
   Thanks for your comment. No ideal about this setting, is requires_llvm better?



##########
tests/python/topi/python/test_topi_upsampling.py:
##########
@@ -101,6 +101,38 @@ def check_target(target, dev):
         check_target(target, dev)
 
 
+@tvm.testing.uses_gpu
+def test_int_div_upsampling():

Review Comment:
   Great suggestion, i will add it asap.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org