You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Ismael Juma (JIRA)" <ji...@apache.org> on 2017/04/05 23:40:42 UTC
[jira] [Commented] (KAFKA-4935) Consider disabling record level CRC
checks for message format V2
[ https://issues.apache.org/jira/browse/KAFKA-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958033#comment-15958033 ]
Ismael Juma commented on KAFKA-4935:
------------------------------------
Whatever we decide, we should remove the following code comment:
{code}
// TODO: The crc is useless for the new message format. Maybe we should let writeTo return the written size?
{code}
> Consider disabling record level CRC checks for message format V2
> ----------------------------------------------------------------
>
> Key: KAFKA-4935
> URL: https://issues.apache.org/jira/browse/KAFKA-4935
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Apurva Mehta
> Fix For: 0.11.0.0
>
>
> With the new message format proposed in KIP-98, the record level CRC has been moved to the the batch header.
> Because we expose the record-level CRC in `RecordMetadata` and `ConsumerRecord`, we currently compute it eagerly based on the key, value and timestamp even though these methods are rarely used. Ideally, we'd deprecate the relevant methods in `RecordMetadata` and `ConsumerRecord` while making the CRC computation lazy. This seems pretty hard to achieve in the Producer without increasing memory retention, but it may be possible to do in the Consumer.
> An alternative option is to return the batch CRC from the relevant methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)