You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/03/11 02:58:34 UTC
[GitHub] [fineract] vidakovic opened a new pull request #2138: FINERACT-1526: Upgrade dependencies
vidakovic opened a new pull request #2138:
URL: https://github.com/apache/fineract/pull/2138
## Description
Some dependency updates (e. g. Checkstyle) required some minor code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #2138: FINERACT-1526: Upgrade dependencies
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #2138:
URL: https://github.com/apache/fineract/pull/2138#discussion_r824486559
##########
File path: docker-compose-community-app.yml
##########
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+version: '3.7'
+services:
+ # Frontend service
+ community-app:
+ image: openmf/community-app:latest
+ container_name: mifos-ui
Review comment:
I'll leave it there as a convenience for anyone who used it. At least it's not in the critical path for the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2138: FINERACT-1526: Upgrade dependencies
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2138:
URL: https://github.com/apache/fineract/pull/2138#issuecomment-1065128230
Have to investigate this failing email campaign test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #2138: FINERACT-1526: Upgrade dependencies
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #2138:
URL: https://github.com/apache/fineract/pull/2138#discussion_r824483143
##########
File path: docker-compose-postgresql.yml
##########
@@ -96,12 +96,12 @@ services:
- FINERACT_DEFAULT_TENANTDB_DESCRIPTION=Default Demo Tenant
# Frontend service
- community-app:
- image: openmf/community-app:latest
- container_name: mifos-ui
- restart: always
- ports:
- - 9090:80
- depends_on:
- fineract-server:
- condition: service_healthy
+ #community-app:
Review comment:
I'd remove it here... and leave the separate docker-compose-community-app.yml as a convenience for anyone who used it... then no one can complain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a change in pull request #2138: FINERACT-1526: Upgrade dependencies
Posted by GitBox <gi...@apache.org>.
galovics commented on a change in pull request #2138:
URL: https://github.com/apache/fineract/pull/2138#discussion_r824471695
##########
File path: docker-compose-postgresql.yml
##########
@@ -96,12 +96,12 @@ services:
- FINERACT_DEFAULT_TENANTDB_DESCRIPTION=Default Demo Tenant
# Frontend service
- community-app:
- image: openmf/community-app:latest
- container_name: mifos-ui
- restart: always
- ports:
- - 9090:80
- depends_on:
- fineract-server:
- condition: service_healthy
+ #community-app:
Review comment:
I guess you want to remove this or uncomment?
##########
File path: docker-compose-community-app.yml
##########
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+version: '3.7'
+services:
+ # Frontend service
+ community-app:
+ image: openmf/community-app:latest
+ container_name: mifos-ui
Review comment:
I think we can remove the container_name from here. I know the original docker-compose files have this specified but it's just going to cause name collisions. The automatic name generation by Docker is fine.
##########
File path: docker-compose.yml
##########
@@ -92,12 +92,12 @@ services:
- FINERACT_DEFAULT_TENANTDB_DESCRIPTION=Default Demo Tenant
# Frontend service
- community-app:
- image: openmf/community-app:latest
- container_name: mifos-ui
- restart: always
- ports:
- - 9090:80
- depends_on:
- fineract-server:
- condition: service_healthy
+ #community-app:
Review comment:
Same here.
##########
File path: fineract-provider/build.gradle
##########
@@ -63,10 +63,10 @@ task prepareInputYaml {
rat.dependsOn prepareInputYaml
resolve {
- logging.captureStandardOutput LogLevel.INFO
+ // logging.captureStandardOutput LogLevel.INFO
Review comment:
You wanna uncomment or remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2138: FINERACT-1526: Upgrade dependencies
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2138:
URL: https://github.com/apache/fineract/pull/2138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #2138: FINERACT-1526: Upgrade dependencies
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #2138:
URL: https://github.com/apache/fineract/pull/2138#discussion_r824483816
##########
File path: fineract-provider/build.gradle
##########
@@ -63,10 +63,10 @@ task prepareInputYaml {
rat.dependsOn prepareInputYaml
resolve {
- logging.captureStandardOutput LogLevel.INFO
+ // logging.captureStandardOutput LogLevel.INFO
Review comment:
Good catch... have to add again, was just temporarily commented out, because of some random Gradle exception in that task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org