[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3023: Decouple Kyuubi JDBC Kerberos from UGI

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3023:
URL: https://github.com/apache/incubator-kyuubi/pull/3023#discussion_r921123057


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/auth/HttpKerberosRequestInterceptor.java:
##########
@@ -61,10 +60,10 @@ protected void addHttpAuthHeader(HttpRequest httpRequest, HttpContext httpContex
       // Locking ensures the tokens are unique in case of concurrent requests
       kerberosLock.lock();
       String kerberosAuthHeader =
-          HttpAuthUtils.getKerberosServiceTicket(principal, host, loggedInSubject);
+          HttpAuthUtils.getKerberosServiceTicket(serverPrincipal, host, loggedInSubject);
       // Set the session key token (Base64 encoded) in the headers
       httpRequest.addHeader(
-          HttpAuthUtils.AUTHORIZATION + ": " + HttpAuthUtils.NEGOTIATE + " ", kerberosAuthHeader);
+          HttpAuthUtils.AUTHORIZATION, HttpAuthUtils.NEGOTIATE + " " + kerberosAuthHeader);

Review Comment:
   This fixed the SPNEGO implementation bug. https://datatracker.ietf.org/doc/html/rfc4559#section-5



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org