You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/11/19 21:21:08 UTC
[kudu-CR] [java] Fix medium SpotBugs issues
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14747
Change subject: [java] Fix medium SpotBugs issues
......................................................................
[java] Fix medium SpotBugs issues
This patch fixes the current SpotBugs issues along with some other minor
cleanup spotted along the way. Either the SpotBugs issues were fixed or
they were added to the excludeFilter as a special case.
Follow on patches will enforce SpotBugs in the pre-commit build.
Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
---
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
A java/config/spotbugs/excludeFilter.xml
M java/gradle/quality.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/build.gradle
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
52 files changed, 401 insertions(+), 181 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14747/1
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml
File java/config/spotbugs/excludeFilter.xml:
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@30
PS1, Line 30: <Class name="~org\.apache\.kudu\.rpc\.RpcHeader.*"/>
> Could you use the <Source/> element to match everything with /proto/ in its
I tried this. It doesn't appear that the `/build/generated/source/proto/main/java` path is available for filtering purposes. I think it's a relative path starting from `org/`.
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 16:05:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@13
PS2, Line 13: enforce SpotBugs
> Once the issue with invoking SpotBugs in PS2 has been addressed, I tried to
I am not sure yet. I am fixing the current issues first and then will look to improve coverage or rule-sets.
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 15:50:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14747
to look at the new patch set (#2).
Change subject: [java] Fix medium SpotBugs issues
......................................................................
[java] Fix medium SpotBugs issues
This patch fixes the current SpotBugs issues along with some other minor
cleanup spotted along the way. Either the SpotBugs issues were fixed or
they were added to the excludeFilter as a special case.
Follow on patches will enforce SpotBugs in the pre-commit build.
Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
---
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
A java/config/spotbugs/excludeFilter.xml
M java/gradle/quality.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/build.gradle
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
52 files changed, 400 insertions(+), 180 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14747/2
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml
File java/config/spotbugs/excludeFilter.xml:
PS1:
> That might be possible. Could it be follow on work?
Yeah for sure.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@28
PS1, Line 28: <Class name="~org\.apache\.kudu\.consensus\.Opid.*"/>
> The actual issue is reported on `Opid$OpId$Builder`
Ah, forgot about the implicit builder nested classes.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@30
PS1, Line 30: <Class name="~org\.apache\.kudu\.rpc\.RpcHeader.*"/>
> I was okay being heavy handed given the ideal outcome is ignoring all Proto
Could you use the <Source/> element to match everything with /proto/ in its path? That would match all the generated code:
./build/generated/source/proto/main/java/org/apache/kudu/consensus/Metadata.java
./build/generated/source/proto/main/java/org/apache/kudu/consensus/Opid.java
./build/generated/source/proto/main/java/org/apache/kudu/consensus/Consensus.java
./build/generated/source/proto/main/java/org/apache/kudu/master/Master.java
...
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 05:39:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14747
to look at the new patch set (#3).
Change subject: [java] Fix medium SpotBugs issues
......................................................................
[java] Fix medium SpotBugs issues
This patch fixes the current SpotBugs issues along with some other minor
cleanup spotted along the way. Either the SpotBugs issues were fixed or
they were added to the excludeFilter as a special case.
Follow on patches will enforce SpotBugs in the pre-commit build.
Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
---
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
A java/config/spotbugs/excludeFilter.xml
M java/gradle/quality.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/build.gradle
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
54 files changed, 407 insertions(+), 182 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14747/3
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 2:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml
File java/config/spotbugs/excludeFilter.xml:
PS1:
For the PB stuff, there are a few classes that lack a PB suffix. Could we rename them in the code while preserving backwards compatibility?
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@28
PS1, Line 28: <Class name="~org\.apache\.kudu\.consensus\.Opid.*"/>
Don't need a .* at the end; it's literally just the class built for the OpId message.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@29
PS1, Line 29: <Class name="~org\.apache\.kudu\.master\.Master.*"/>
So this is for the "service endpoint" generated code, right? What about the tablet service endpoints?
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@30
PS1, Line 30: <Class name="~org\.apache\.kudu\.rpc\.RpcHeader.*"/>
You could restrict this to just RequestHeader and ResponseHeader; every other top-level message in rpc_header.proto is suffixed with a PB.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@79
PS1, Line 79: <!-- The retry rule doesn't need to be read. -->
We should add guidance here (or maybe in RetryRule itself) to use a well-known naming scheme for RetryRule instantiations to avoid running afoul of SpotBugs.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@86
PS1, Line 86: TestKuduTable
Sentence fragment?
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@96
PS1, Line 96: <!-- Tests use i % 2 == 1 frequently to alternate behavior. -->
: <Class name="~org\.apache\.kudu.*Test.*"/>
: <Bug pattern="IM_BAD_CHECK_FOR_ODD" />
Any interest in converting these into negated "check for even" instead?
Could be done in a follow-up.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@103
PS1, Line 103: <Class name="org.apache.kudu.backup.KuduBackupRDD"/>
: <Field name="options" />
: <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
Anything worth documenting for this case?
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@116
PS1, Line 116: the
they
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@125
PS1, Line 125: <!-- The nullable annotation is from Guava and therefore can't be changed. -->
I don't see these annotations in TestFlexiblePartitioning.java. What am I looking for?
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@151
PS1, Line 151: <Class name="org.apache.kudu.spark.kudu.KuduRDD"/>
: <Or>
: <Field name="options" />
: <Field name="projectedCols"/>
: </Or>
: <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
Anything worth documenting?
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@161
PS1, Line 161: <!-- The Random is called in the super constructor and can't be re-used. -->
: <Or>
: <Class name="org.apache.kudu.test.CapturingLogAppender"/>
: <Class name="org.apache.kudu.test.CapturingToFileLogAppender"/>
: </Or>
: <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
FWIW, we could use a static AtomicInt counter here instead of a one-shot Random. Or even a static Random.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java:
http://gerrit.cloudera.org:8080/#/c/14747/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java@173
PS1, Line 173: return Objects.hashCode((Object) bytes);
Is this preferred to Arrays.hashCode(bytes)?
http://gerrit.cloudera.org:8080/#/c/14747/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java:
http://gerrit.cloudera.org:8080/#/c/14747/2/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java@60
PS2, Line 60: Boolean isLocal = isLocalAddressCache.get(resolvedAddr);
: if (isLocal == null) {
: isLocal = NetUtil.isLocalAddress(resolvedAddr);
: isLocalAddressCache.putIfAbsent(resolvedAddr, isLocal);
: }
computeIfAbsent is probably a clearer way to do this.
http://gerrit.cloudera.org:8080/#/c/14747/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java:
http://gerrit.cloudera.org:8080/#/c/14747/2/java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java@174
PS2, Line 174: thread.start();
So previously the count was actually being invoked serially? Nice.
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Nov 2019 23:50:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 1:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@7
PS2, Line 7: SpotBugs
> It would be nice to add information README.md on how to run the checks (thi
This is a bug from the previous/parent patch, I will fix it there.
I will update the readme in a follow up change. For now, `check` works, but you could also run `gradle spotBugs` to just run the spotBugs checks. `gradle tasks` will show all the available common tasks.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml
File java/config/spotbugs/excludeFilter.xml:
PS1:
> For the PB stuff, there are a few classes that lack a PB suffix. Could we r
That might be possible. Could it be follow on work?
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@28
PS1, Line 28: <Class name="~org\.apache\.kudu\.consensus\.Opid.*"/>
> Don't need a .* at the end; it's literally just the class built for the OpI
The actual issue is reported on `Opid$OpId$Builder`
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@29
PS1, Line 29: <Class name="~org\.apache\.kudu\.master\.Master.*"/>
> So this is for the "service endpoint" generated code, right? What about the
I only included the non PB classes that reported issues instead of covering all of them.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@30
PS1, Line 30: <Class name="~org\.apache\.kudu\.rpc\.RpcHeader.*"/>
> You could restrict this to just RequestHeader and ResponseHeader; every oth
I was okay being heavy handed given the ideal outcome is ignoring all Protobuf source.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@79
PS1, Line 79: <!-- The retry rule doesn't need to be read. -->
> We should add guidance here (or maybe in RetryRule itself) to use a well-kn
I will add a note here. It should be obvious to avoid going forward once the pre-commit breaks on SpotBugs issues.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@86
PS1, Line 86: TestKuduTable
> Sentence fragment?
oops
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@96
PS1, Line 96: <!-- Tests use i % 2 == 1 frequently to alternate behavior. -->
: <Class name="~org\.apache\.kudu.*Test.*"/>
: <Bug pattern="IM_BAD_CHECK_FOR_ODD" />
> Any interest in converting these into negated "check for even" instead?
Will add a TODO for follow up.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@103
PS1, Line 103: <Class name="org.apache.kudu.backup.KuduBackupRDD"/>
: <Field name="options" />
: <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
> Anything worth documenting for this case?
Done
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@116
PS1, Line 116: the
> they
Done
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@125
PS1, Line 125: <!-- The nullable annotation is from Guava and therefore can't be changed. -->
> I don't see these annotations in TestFlexiblePartitioning.java. What am I l
It's from the guava Predicate implementations. Guava is adding @Nullable on the parent apply method and that's being detected here for some reason. I will be more specific.
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@151
PS1, Line 151: <Class name="org.apache.kudu.spark.kudu.KuduRDD"/>
: <Or>
: <Field name="options" />
: <Field name="projectedCols"/>
: </Or>
: <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
> Anything worth documenting?
Done
http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@161
PS1, Line 161: <!-- The Random is called in the super constructor and can't be re-used. -->
: <Or>
: <Class name="org.apache.kudu.test.CapturingLogAppender"/>
: <Class name="org.apache.kudu.test.CapturingToFileLogAppender"/>
: </Or>
: <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
> FWIW, we could use a static AtomicInt counter here instead of a one-shot Ra
Done
http://gerrit.cloudera.org:8080/#/c/14747/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java:
http://gerrit.cloudera.org:8080/#/c/14747/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java@173
PS1, Line 173: return Objects.hashCode((Object) bytes);
> Is this preferred to Arrays.hashCode(bytes)?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 03:48:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 2:
(1 comment)
I just tried to fetch the changelist from gerrit and run it, but it failed.
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@7
PS2, Line 7: SpotBugs
It would be nice to add information README.md on how to run the checks (this is './gradlew check', right?)
BTW, when I tried to run it using this patch (i.e. fetching it from gerrit), I got the error below. What am I missing?
aserbin-mbp:java[java-lint]$ ./gradlew check
> Task :kudu-backup:checkstyleMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':kudu-backup:checkstyleMain'.
> Unable to create Root Module: config {/Users/aserbin/Projects/kudu/java/config/checkstyle/checkstyle.xml}, classpath {/Users/aserbin/Projects/kudu/java/kudu-backup/build/classes/java/main:/Users/aserbin/Projects/kudu/java/kudu-backup/build/classes/scala/main:/Users/aserbin/Projects/kudu/java/kudu-backup/build/resources/main:/Users/aserbin/Projects/kudu/java/kudu-backup-common/build/libs/kudu-backup-common-1.12.0-SNAPSHOT.jar:/Users/aserbin/Projects/kudu/java/kudu-client/build/libs/kudu-client-1.12.0-SNAPSHOT.jar:/Users/aserbin/Projects/kudu/java/kudu-spark/build/libs/kudu-spark2_2.11-1.12.0-SNAPSHOT.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.github.scopt/scopt_2.11/3.7.1/a9ac897201de7c5059b354a8f1cabff0274f499d/scopt_2.11-3.7.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.yetus/audience-annotations/0.11.1/afa58b3ee7702df26b6ea707f2a7284fd8286f3d/audience-annotations-0.11.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.protobuf/protobuf-java-util/3.10.0/a68c906db83e93babbb4024ce91e7441bb7598dd/protobuf-java-util-3.10.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.protobuf/protobuf-java/3.10.0/410b61dd0088aab4caa05739558d43df248958c9/protobuf-java-3.10.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-api/1.7.29/e56bf4473a4c6b71c7dd397a833dce86d1993d9d/slf4j-api-1.7.29.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.stumbleupon/async/1.4.1/25b9507a58570c349d32a80e395bc29da091059c/async-1.4.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.code.gson/gson/2.8.5/f645ed69d595b24d4cf8b3fbb64cc505bede8829/gson-2.8.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-sql_2.11/2.4.4/e6a748c169978b0d070002f7849e4edc9bbb3db4/spark-sql_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-catalyst_2.11/2.4.4/ba9237eac7523f0d61e104bc6c35f01240020241/spark-catalyst_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-core_2.11/2.4.4/98226adb9bd1fb12479f5da1888e22b0fc89e1aa/spark-core_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-avro_2.11/2.4.4/afe0a3ca09a76ebb89fe27b9bc5099f4ca737093/spark-avro_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-launcher_2.11/2.4.4/fec76e9fa841caa45508e224c20435bbf5b57c20/spark-launcher_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-kvstore_2.11/2.4.4/a7e2e06f9e251ff7f3af3aa8acb3bbf1eddf30be/spark-kvstore_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-unsafe_2.11/2.4.4/878f466ff5c0010bd229d5308dbf684aaa0c5545/spark-unsafe_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-sketch_2.11/2.4.4/a5c79cccb57cde4404fb31f212a0cb66f5412215/spark-sketch_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-tags_2.11/2.4.4/d27ee182bac18b49a26f79fe3cd4d484c847ed13/spark-tags_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.twitter/chill_2.11/0.9.3/432cc2832f1deee574535b3dbf7be0a478e9ab0f/chill_2.11-0.9.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.json4s/json4s-jackson_2.11/3.5.3/733a711a66d8eecbde9cfd7618235eae0d349a6d/json4s-jackson_2.11-3.5.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.module/jackson-module-scala_2.11/2.6.7.1/1cacab783de67e3c3d2377aa604acaba3df399cd/jackson-module-scala_2.11-2.6.7.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.json4s/json4s-core_2.11/3.5.3/4ea70f8fec94e03341c81d21e924d8c469ef0b61/json4s-core_2.11-3.5.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.scala-lang/scala-reflect/2.11.12/2bb23c13c527566d9828107ca4108be2a2c06f01/scala-reflect-2.11.12.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.scala-lang.modules/scala-parser-combinators_2.11/1.1.0/fbf4d9948b22f37c658c8c7712a621a732798b13/scala-parser-combinators_2.11-1.1.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.json4s/json4s-ast_2.11/3.5.3/f1b60133c0667114a02e122d7f05e334dadc03a7/json4s-ast_2.11-3.5.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.json4s/json4s-scalap_2.11/3.5.3/a78590f694a565a63ca6ba0eae8cd19f52d79ec4/json4s-scalap_2.11-3.5.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.scala-lang.modules/scala-xml_2.11/1.0.6/4ebd108453e6455351c0ec50d32509ae1154fdb1/scala-xml_2.11-1.0.6.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.scala-lang/scala-library/2.11.12/bf5534e6fec3d665bd6419c952a929a8bdd4b591/scala-library-2.11.12.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.avro/avro-mapred/1.8.2/8d31caedebfc3f8801981b0f5b501a673eca1bb6/avro-mapred-1.8.2-hadoop2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.avro/avro-ipc/1.8.2/f4b0a97be342337431dada7b3c8d8cd62993684c/avro-ipc-1.8.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-client/2.6.5/d7c7537441aa4478cdb086205971b9eeccdf5dd5/hadoop-client-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-common/2.6.5/775c6ba9b08cf8ec42e27ea0730b69cc990c69ea/hadoop-common-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.avro/avro/1.8.2/91e3146dfff4bd510181032c8276a3a0130c0697/avro-1.8.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.slf4j/jul-to-slf4j/1.7.16/2d5b546c5557dcbf08c3a381d7dc9bd275a602c1/jul-to-slf4j-1.7.16.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.slf4j/jcl-over-slf4j/1.7.16/34e48073884704ac987d3d1a1ab9b60e62028a9/jcl-over-slf4j-1.7.16.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-mapreduce-client-app/2.6.5/1c1efaa36ef29cb27c9198e2b4a8544c5a02cf3b/hadoop-mapreduce-client-app-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-mapreduce-client-jobclient/2.6.5/988e9987308067351542277523ee6bf5cd9a798/hadoop-mapreduce-client-jobclient-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-mapreduce-client-shuffle/2.6.5/2008b781ee446daadf60c201548567477b9effc6/hadoop-mapreduce-client-shuffle-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-mapreduce-client-common/2.6.5/22351b44ef35dfd8ef352cf9df4d41eb4b549068/hadoop-mapreduce-client-common-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-mapreduce-client-core/2.6.5/38383ecce4016373f75c957f6af969820d3d303f/hadoop-mapreduce-client-core-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-auth/2.6.5/dc366f22960ec35c8b8771b40dcb6437d4199416/hadoop-auth-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.curator/curator-recipes/2.6.0/8736b0fc42e6bf006d585fe85c90aaa4ade5cbef/curator-recipes-2.6.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.curator/curator-framework/2.6.0/81a699c39d127b5b4ff97cc77da7650b53e5b5ed/curator-framework-2.6.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.curator/curator-client/2.6.0/b9007c357ad1a78066fc6004e8b1feaa2318f6f3/curator-client-2.6.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-yarn-server-nodemanager/2.6.5/d7dfcc7bef8155aa9e30a2563ed1869f778bae72/hadoop-yarn-server-nodemanager-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-yarn-server-common/2.6.5/23807d9f1291fa0803243f16e6ec1db79b4c8150/hadoop-yarn-server-common-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.zookeeper/zookeeper/3.4.6/1b2502e29da1ebaade2357cd1de35a855fa3755/zookeeper-3.4.6.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-log4j12/1.7.16/54c6dd23a7c420e40b8848e962d5f2a3534260af/slf4j-log4j12-1.7.16.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-network-shuffle_2.11/2.4.4/482b0bdf90f798b53cf124c8b22d5ed31eb88d2f/spark-network-shuffle_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.spark/spark-network-common_2.11/2.4.4/51e8496ecf82b993c8e398b3fbdbe4c368a411c0/spark-network-common_2.11-2.4.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/io.dropwizard.metrics/metrics-jvm/3.1.5/42fe531a5873bd56dbca6e4b7678912b5df2a19/metrics-jvm-3.1.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/io.dropwizard.metrics/metrics-json/3.1.5/46debd1b9f1b4ada07d084dffc3eb272e87c6f62/metrics-json-3.1.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/io.dropwizard.metrics/metrics-graphite/3.1.5/366b727fe0e64fe43b60a3e2455c9dcc149cc0d3/metrics-graphite-3.1.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/io.dropwizard.metrics/metrics-core/3.1.5/b07d2c8b79a11dd0a7d6d48adc96f396d7b58808/metrics-core-3.1.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.orc/orc-core/1.5.5/31c4c6c741a558d68c76c4cf88fb06fdca82adc/orc-core-1.5.5-nohive.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.arrow/arrow-vector/0.10.0/1883c9bae9650ca76771dbbcbb4a8744070e5043/arrow-vector-0.10.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.orc/orc-shims/1.5.5/6a639c228ab66601398fd2d94d441d4c6a9a7c8e/orc-shims-1.5.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.parquet/parquet-hadoop/1.10.1/374c8d94b49388266aeb4d96ae2d19e6fe957b26/parquet-hadoop-1.10.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.parquet/parquet-column/1.10.1/10999fbe40cd5d26e7e800a9cf8e6cc0fcf1c99e/parquet-column-1.10.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.parquet/parquet-encoding/1.10.1/b495a7817b434be694965059c0cd4c255a94c57d/parquet-encoding-1.10.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.parquet/parquet-common/1.10.1/2a6b665654098c2321f7ab95c48096734026638d/parquet-common-1.10.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.parquet/parquet-format/2.4.0/d4508d385899dfb2dcecdc08fc5e4a5e6b747057/parquet-format-2.4.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.arrow/arrow-memory/0.10.0/d9301e56042f0734b5844ddf265d1f044ae0c6d8/arrow-memory-0.10.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-yarn-client/2.6.5/f04ea6144290f73bda0859316e84b7e446c8482c/hadoop-yarn-client-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-yarn-common/2.6.5/c318b7a43e0cefbc97ca70e84bebd0e194b2c9bc/hadoop-yarn-common-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.directory.server/apacheds-kerberos-codec/2.0.0-M15/1c16e4e477183641c5f0dd5cdecd27ec331bacb5/apacheds-kerberos-codec-2.0.0-M15.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.directory.server/apacheds-i18n/2.0.0-M15/71c61c84683152ec2a6a65f3f96fe534e304fa22/apacheds-i18n-2.0.0-M15.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.directory.api/api-asn1-api/1.0.0-M20/5e6486ffa3125ba44dc410ead166e1d6ba8ac76d/api-asn1-api-1.0.0-M20.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.directory.api/api-util/1.0.0-M20/a871abf060b3cf83fc6dc4d7e3d151fce50ac3cb/api-util-1.0.0-M20.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.spark-project.spark/unused/1.0.0/205fe37a2fade6ce6dfcf8eff57ed21a4a1c22af/unused-1.0.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.module/jackson-module-paranamer/2.7.9/47ee876c1145e3e39a9f028d9b23c2e3b6c9be6a/jackson-module-paranamer-2.7.9.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.thoughtworks.paranamer/paranamer/2.8/619eba74c19ccf1da8ebec97a2d7f8ba05773dd6/paranamer-2.8.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.twitter/chill-java/0.9.3/f7670c73b068b3beeba8f0ed284e08b8d38eae02/chill-java-0.9.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.xbean/xbean-asm6-shaded/4.8/34bd7c7236dfa87de173e4328354ba0701a374c/xbean-asm6-shaded-4.8.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.xml.bind/jaxb-api/2.2.2/aeb3021ca93dde265796d82015beecdcff95bf09/jaxb-api-2.2.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.activation/activation/1.1.1/485de3a253e23f645037828c07f1d7f1af40763a/activation-1.1.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.servlet/javax.servlet-api/3.1.0/3cd63d075497751784b2fa84be59432f4905bf7c/javax.servlet-api-3.1.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.commons/commons-lang3/3.5/6c6c702c89bfff3cd9e80b04d668c5e190d588c6/commons-lang3-3.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.commons/commons-math3/3.4.1/3ac44a8664228384bc68437264cf7c4cf112f579/commons-math3-3.4.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.code.findbugs/jsr305/3.0.2/25ea2e8b0c338a877313bd4672d3fe056ea78f0d/jsr305-3.0.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-hdfs/2.6.5/8bd0f95e29b9ba7960b4239a7f3706b37b183652/hadoop-hdfs-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/log4j/log4j/1.2.17/5af35056b4d257e4b64b9e8069c0746e8b08629f/log4j-1.2.17.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.ning/compress-lzf/1.0.3/3e1495b0c532ebe58f1c8b1c5d9b3bdcc6c1504c/compress-lzf-1.0.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.xerial.snappy/snappy-java/1.1.7.3/241bb74a1eb37d68a4e324a4bc3865427de0a62d/snappy-java-1.1.7.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.lz4/lz4-java/1.4.0/db5083b84299ad982a19677316da9a49363ad6e0/lz4-java-1.4.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.github.luben/zstd-jni/1.3.2-2/bde2d9e205aa832222a02e59ab155f42efefbf44/zstd-jni-1.3.2-2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.roaringbitmap/RoaringBitmap/0.7.45/cf97912280a8bc6f740d0e2c15b8acdfeb683ac3/RoaringBitmap-0.7.45.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-net/commons-net/3.1/2298164a7c2484406f2aa5ac85b205d39019896f/commons-net-3.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.containers/jersey-container-servlet/2.22.2/d90487b9809f822af7731abb8896a2183e7c4a0c/jersey-container-servlet-2.22.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.containers/jersey-container-servlet-core/2.22.2/212c534c5b030594ccf5c4b929e8f7cbf26eb1ba/jersey-container-servlet-core-2.22.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.core/jersey-server/2.22.2/5ede3e5f98f8b14d31d1d0fffe9908df2bd41c0f/jersey-server-2.22.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.core/jersey-client/2.22.2/1712fff037ce5a59e3d67f90fff29222989799ee/jersey-client-2.22.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.media/jersey-media-jaxb/2.22.2/7a9adf97790a92d09a1f2c027dbd34af15ffee04/jersey-media-jaxb-2.22.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.core/jersey-common/2.22.2/1209b89878b60ce7d49afadeff7522d2fde0e217/jersey-common-2.22.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/io.netty/netty-all/4.1.17.Final/43142cd1d6a0ea281eb6a4990354b4d3ad23dd43/netty-all-4.1.17.Final.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/io.netty/netty/3.9.9.Final/58e0a7e7ff773f84d02d4f006ae9dd31ad22a0b1/netty-3.9.9.Final.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.clearspring.analytics/stream/2.7.0/9998f8cf87d329fef226405f8d519638cfe1431d/stream-2.7.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-databind/2.6.7.1/306775aeb5164835a1dcbdf3f945587045cfb3b5/jackson-databind-2.6.7.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.ivy/ivy/2.4.0/5abe4c24bbe992a9ac07ca563d5bd3e8d569e9ed/ivy-2.4.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/oro/oro/2.0.8/5592374f834645c4ae250f4c9fbb314c9369d698/oro-2.0.8.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/net.razorvine/pyrolite/4.13/b71a4668b0c4194486832fe7ce161eed2d0d12cb/pyrolite-4.13.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/net.sf.py4j/py4j/0.10.7/e733e888c2e798ea15802f12a9f3130949ca741f/py4j-0.10.7.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.commons/commons-crypto/1.0.0/7938f66b01f62f03ef8af8a64401e85e45d51c5d/commons-crypto-1.0.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.univocity/univocity-parsers/2.7.3/2d7b2cbe31d203333e0ce2b99ddb9f8afa03fc42/univocity-parsers-2.7.3.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.orc/orc-mapreduce/1.5.5/fc8c58a4bd3a3523e42eec3eee61810e92ab6fe4/orc-mapreduce-1.5.5-nohive.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.codehaus.jackson/jackson-mapper-asl/1.9.13/1ee2f2bed0e5dd29d1cb155a166e6f8d50bbddb7/jackson-mapper-asl-1.9.13.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.codehaus.jackson/jackson-jaxrs/1.9.13/534d72d2b9d6199dd531dfb27083dd4844082bba/jackson-jaxrs-1.9.13.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.codehaus.jackson/jackson-xc/1.9.13/e3480072bc95c202476ffa1de99ff7ee9149f29c/jackson-xc-1.9.13.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.codehaus.jackson/jackson-core-asl/1.9.13/3c304d70f42f832e0a86d45bd437f692129299a4/jackson-core-asl-1.9.13.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.commons/commons-compress/1.8.1/a698750c16740fd5b3871425f4cb3bbaa87f529d/commons-compress-1.8.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.tukaani/xz/1.5/9c64274b7dbb65288237216e3fae7877fd3f2bee/xz-1.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-httpclient/commons-httpclient/3.1/964cd74171f427720480efdec40a7c7f6e58426a/commons-httpclient-3.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.httpcomponents/httpclient/4.2.5/666e26e76f2e87d84e4f16acb546481ae1b8e9a6/httpclient-4.2.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-codec/commons-codec/1.10/4b95f4897fa13f2cd904aee711aeafc0c5295cd8/commons-codec-1.10.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.esotericsoftware/kryo-shaded/4.0.2/e8c89779f93091aa9cb895093402b5d15065bf88/kryo-shaded-4.0.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-yarn-api/2.6.5/7f567c6bb57673a44cd397d30adf63eb037769a1/hadoop-yarn-api-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.hadoop/hadoop-annotations/2.6.5/29262f09feff4e46beb447e2986319ad7d19f743/hadoop-annotations-2.6.5.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.fusesource.leveldbjni/leveldbjni-all/1.8/707350a2eeb1fa2ed77a32ddb3893ed308e941db/leveldbjni-all-1.8.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-core/2.7.9/9b530cec4fd2eb841ab8e79f19fc7cf0ec487b2/jackson-core-2.7.9.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.fasterxml.jackson.core/jackson-annotations/2.6.7/7e08eafe72cbd11c955d92109108bd2bfaab979e/jackson-annotations-2.6.7.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.htrace/htrace-core/3.0.4/d7461828faf28411f37f8570d896292db277d838/htrace-core-3.0.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/16.0.1/5fa98cd1a63c99a44dd8d3b77e4762b066a5d0c5/guava-16.0.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.roaringbitmap/shims/0.7.45/efcebd3284aaba8bc0c72040018a72e8ba7530bc/shims-0.7.45.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.ws.rs/javax.ws.rs-api/2.0.1/104e9c2b5583cfcfeac0402316221648d6d8ea6b/javax.ws.rs-api-2.0.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.hk2/hk2-locator/2.4.0-b34/1451fc3e5b7f00d7a5ca0feaff2c1bf68be5ac91/hk2-locator-2.4.0-b34.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.hk2/hk2-api/2.4.0-b34/1017432e219dbd1d4a1121b2d7e87c5b2f0bcfb9/hk2-api-2.4.0-b34.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.hk2.external/javax.inject/2.4.0-b34/a6a3d4935af7b03e44126b5aac2c2a0ce98fe6e9/javax.inject-2.4.0-b34.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.annotation/javax.annotation-api/1.2/479c1e06db31c432330183f5cae684163f186146/javax.annotation-api-1.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.jersey.bundles.repackaged/jersey-guava/2.22.2/7422c693c89640c9685dfa99dbef2da745aa4617/jersey-guava-2.22.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.hk2/osgi-resource-locator/1.0.1/4ed2b2d4738aed5786cfa64cba5a332779c4c708/osgi-resource-locator-1.0.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.validation/validation-api/1.1.0.Final/8613ae82954779d518631e05daa73a6a954817d5/validation-api-1.1.0.Final.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.codehaus.janino/janino/3.0.9/ddfd261063f2e6300e4c884aeef5f145dd0b38d/janino-3.0.9.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.codehaus.janino/commons-compiler/3.0.9/6aac3c03d02dcab0d59f77ff00b682f5320e54e9/commons-compiler-3.0.9.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.antlr/antlr4-runtime/4.7/30b13b7efc55b7feea667691509cf59902375001/antlr4-runtime-4.7.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.protobuf/protobuf-java/2.5.0/a10732c76bfacdbd633a7eb0f7968b1059a65dfa/protobuf-java-2.5.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-configuration/commons-configuration/1.6/32cadde23955d7681b0d94a2715846d20b425235/commons-configuration-1.6.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-lang/commons-lang/2.6/ce1edb914c94ebc388f086c6827e8bdeec71ac2/commons-lang-2.6.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/io.airlift/aircompressor/0.10/bf8305930ec675964bd68599c702ffb32df4d1e6/aircompressor-0.10.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.parquet/parquet-jackson/1.10.1/d61d80ada3a2c6b0c9ed06bd689cfd428de96112/parquet-jackson-1.10.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.arrow/arrow-format/0.10.0/85347ddea82e80b0aa14efd25aefb9a009d8ff0f/arrow-format-0.10.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/joda-time/joda-time/2.9.9/f7b520c458572890807d143670c9b24f4de90897/joda-time-2.9.9.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.carrotsearch/hppc/0.7.2/710398361f2ae8fd594a133e3619045c16b24137/hppc-0.7.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.vlkan/flatbuffers/1.2.0-3f79e055/b4a3fa3b6f768a99c2540e8b96b83bbb051f926c/flatbuffers-1.2.0-3f79e055.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.esotericsoftware/minlog/1.3.0/ff07b5f1b01d2f92bb00a337f9a94873712f0827/minlog-1.3.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.objenesis/objenesis/2.5.1/272bab9a4e5994757044d1fc43ce480c8cb907a4/objenesis-2.5.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-cli/commons-cli/1.2/2bf96b7aa8b611c177d329452af1dc933e14501c/commons-cli-1.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/xmlenc/xmlenc/0.52/d82554efbe65906d83b3d97bd7509289e9db561a/xmlenc-0.52.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-io/commons-io/2.4/b1b6ea3b7e4aa4f492509a4952029cd8e48019ad/commons-io-2.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-collections/commons-collections/3.2.2/8ad72fe39fa8c91eaaf12aadb21e0c3661fe26d5/commons-collections-3.2.2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.code.gson/gson/2.2.4/a60a5e993c98c864010053cb901b7eab25306568/gson-2.2.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.mortbay.jetty/jetty-util/6.1.26/e5642fe0399814e1687d55a3862aa5a3417226a9/jetty-util-6.1.26.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/xerces/xercesImpl/2.9.1/7bc7e49ddfe4fb5f193ed37ecc96c12292c8ceb6/xercesImpl-2.9.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.hk2/hk2-utils/2.4.0-b34/aacce18411fffef9621d8fc91464ca0477119c38/hk2-utils-2.4.0-b34.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.glassfish.hk2.external/aopalliance-repackaged/2.4.0-b34/3d5e856dbc91a3a2b0bcb3a3424f8b62421ae4cf/aopalliance-repackaged-2.4.0-b34.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.javassist/javassist/3.18.1-GA/d9a09f7732226af26bf99f19e2cffe0ae219db5b/javassist-3.18.1-GA.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-digester/commons-digester/1.8/dc6a73fdbd1fa3f0944e8497c6c872fa21dca37e/commons-digester-1.8.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/jline/jline/0.9.94/99a18e9a44834afdebc467294e1138364c207402/jline-0.9.94.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/xml-apis/xml-apis/1.3.04/90b215f48fe42776c8c7f6e3509ec54e84fd65ef/xml-apis-1.3.04.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/3.0/9d84f15fe35e2c716a02979fb62f50a29f38aefa/guice-3.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.inject/javax.inject/1/6975da39a7040257bd51d21a231b76c915872d38/javax.inject-1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/commons-beanutils/commons-beanutils/1.7.0/5675fd96b29656504b86029551973d60fb41339b/commons-beanutils-1.7.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.apache.httpcomponents/httpcore/4.2.4/3b7f38df6de5dd8b500e602ae8c2dd5ee446f883/httpcore-4.2.4.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/junit/junit/3.8.1/99129f16442844f6a4a11ae22fbbee40b14d774f/junit-3.8.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.codehaus.jettison/jettison/1.1/1a01a2a1218fcf9faa2cc2a6ced025bdea687262/jettison-1.1.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/javax.xml.stream/stax-api/1.0-2/d6337b0de8b25e53e81b922352fbea9f9f57ba0b/stax-api-1.0-2.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/aopalliance/aopalliance/1.0/235ba8b489512805ac13a8f9ea77a1ca5ebe3e8/aopalliance-1.0.jar:/Users/aserbin/.gradle/caches/modules-2/files-2.1/org.sonatype.sisu.inject/cglib/2.2.1-v20090111/7ce5e983fd0e6c78346f4c9cbfa39d83049dda2/cglib-2.2.1-v20090111.jar}.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 29s
35 actionable tasks: 9 executed, 26 up-to-date
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 00:22:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@7
PS2, Line 7: SpotBugs
> This is a bug from the previous/parent patch, I will fix it there.
Thank you for fixing that. Now it works for me (i.e. './gradlew check' doesn't output such an error).
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@13
PS2, Line 13: enforce SpotBugs
Once the issue with invoking SpotBugs in PS2 has been addressed, I tried to run it against the code again, and it reported 'all is well':
aserbin-mbp:java[java-lint]$ ./gradlew spotBugs
Starting a Gradle Daemon (subsequent builds will be faster)
BUILD SUCCESSFUL in 1m 33s
89 actionable tasks: 22 executed, 67 up-to-date
However, java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java contained the bug that was fixed in 91d196f33 (i.e. the connection negotiation bug addressed recently).
Does it mean SpotBugs is not able to detect such issues, and we should resort to something else (i.e. add some other lint tool) to detect those? I know that the code inspection of IntelliJ is able to detect the bug, at least in 2018.3.4 Community Edition.
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 06:22:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@13
PS2, Line 13: enforce SpotBugs
> I am not sure yet. I am fixing the current issues first and then will look
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Nov 2019 18:36:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Fix medium SpotBugs issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues
......................................................................
[java] Fix medium SpotBugs issues
This patch fixes the current SpotBugs issues along with some other minor
cleanup spotted along the way. Either the SpotBugs issues were fixed or
they were added to the excludeFilter as a special case.
Follow on patches will enforce SpotBugs in the pre-commit build.
Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Reviewed-on: http://gerrit.cloudera.org:8080/14747
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
A java/config/spotbugs/excludeFilter.xml
M java/gradle/quality.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Bytes.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPartitioner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceFrame.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartitionPruner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-jepsen/build.gradle
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/HadoopTestingUtility.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/build.gradle
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/SparkSQLTest.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
54 files changed, 407 insertions(+), 182 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)