[GitHub] [flink] theoDiefenthal opened a new pull request #8513: [FLINK-12147] [metrics] Error for monitor kafka metrics when Use influxDB metr…

[GitBox <gi...@apache.org>]

theoDiefenthal opened a new pull request #8513:  [FLINK-12147] [metrics] Error for monitor kafka metrics when Use influxDB metr…
URL: https://github.com/apache/flink/pull/8513
 
 
   ## What is the purpose of the change
   
   As InfluxDB doesn't support infinity values in float/double, we just don't send them to influx . There is no behavioral change here as InfluxDB wouldn't store those values anyways, but we are not going to pollute our logs with influxdb partial write errors about each sent infinity value on each report.
   
   
   ## Brief change log
   
   When submitting metrics, check the current metric values and ignore them if they are +-infinity, so that they are not sent. 
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as InfluxDBReporter.testMetricReporting . The test was extended in order to make sure that the invalid values are filtered out correctly. 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services