[GitHub] [airflow] raphaelauv commented on a change in pull request #19332: Add a skip parameter to Variable to skip the secret backend

[GitBox <gi...@apache.org>]

raphaelauv commented on a change in pull request #19332:
URL: https://github.com/apache/airflow/pull/19332#discussion_r741727692



##########
File path: airflow/models/variable.py
##########
@@ -124,15 +125,18 @@ def get(
         key: str,
         default_var: Any = __NO_DEFAULT_SENTINEL,
         deserialize_json: bool = False,
+        skip_external_backends: bool = False,

Review comment:
       the "problem" is that the `LocalFilesystemBackend` need to be setup as a secret_backend https://airflow.apache.org/docs/apache-airflow/stable/security/secrets/secrets-backend/local-filesystem-secrets-backend.html
   
   but we don't want skip it cause it's not an "external" backend 
   
   so `skip_secret_backend` will not be very clear for people with a LocalFilesystemBackend setup
   
   that's why originally I come up with the name `skip_external_backends`
   
   what should we do ?
   
   the documentation of the arg should precise the 3 not skipped backends ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org