You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/09/06 20:14:19 UTC
[GitHub] couchdb-couch-index pull request #19: Do not use config subscription in couc...
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch-index/pull/19
Do not use config subscription in couch_index
The simple fact that we call config:subscribe_for_changes causes the hike in memory consumed by couch_index process. Monitoring the changes for "query_server_config.commit_freq" is not worth it. We would just call config:get_index when we need to.
COUCHDB-3135
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-index 3135-remove_config_subscribe_from_couch_index
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-index/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 91a56c96cc468303b4f45dab9801285151c04b36
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2016-09-06T20:07:28Z
Do not use config subscription in couch_index
COUCHDB-3135
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-index pull request #19: Do not use config subscription in couc...
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-index/pull/19#discussion_r77710187
--- Diff: src/couch_index.erl ---
@@ -30,16 +29,14 @@
-define(CHECK_INTERVAL, 600000). % 10 minutes
--define(RELISTEN_DELAY, 5000).
--define(CONFIG_SUBSCRIPTION, [{"query_server_config", "commit_freq"}]).
-record(st, {
mod,
idx_state,
updater,
compactor,
waiters=[],
- commit_delay,
+ commit_delay, %% not used anymore
--- End diff --
You should remove it then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-index issue #19: Do not use config subscription in couch_index
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-couch-index/pull/19
+1 after removing the unused record field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-index pull request #19: Do not use config subscription in couc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-index/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-index issue #19: Do not use config subscription in couch_index
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-index/pull/19
(can be merged for 2.0)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-index issue #19: Do not use config subscription in couch_index
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-index/pull/19
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---