You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/05 06:45:28 UTC
[GitHub] [hudi] wuwenchi opened a new pull request, #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
wuwenchi opened a new pull request, #7378:
URL: https://github.com/apache/hudi/pull/7378
### Change Logs
check preCombine fields in "createTable"
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1415478562
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
}, {
"hash" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895",
"triggerID" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f268edf5c55b638ffc382621ba34fbbc2fe697f5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836)
* a974f60952afa708af472ef6019b2ce8058d32d4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1415821490
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
}, {
"hash" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895",
"triggerID" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"triggerType" : "PUSH"
}, {
"hash" : "ce363216b67ac466c5a143d805159dc3a5bafc9a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ce363216b67ac466c5a143d805159dc3a5bafc9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a974f60952afa708af472ef6019b2ce8058d32d4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895)
* ce363216b67ac466c5a143d805159dc3a5bafc9a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wuwenchi commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "wuwenchi (via GitHub)" <gi...@apache.org>.
wuwenchi commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1416085628
@danny0405 Done. All checks have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1411739578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f268edf5c55b638ffc382621ba34fbbc2fe697f5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wuwenchi commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by GitBox <gi...@apache.org>.
wuwenchi commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1336826243
@danny0405 Can you help review it? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7378:
URL: https://github.com/apache/hudi/pull/7378#discussion_r1086317118
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalog.java:
##########
@@ -303,6 +306,21 @@ public void createTable(ObjectPath tablePath, CatalogBaseTable catalogTable, boo
options.put(TableOptionProperties.PK_CONSTRAINT_NAME, resolvedSchema.getPrimaryKey().get().getName());
options.put(TableOptionProperties.PK_COLUMNS, pkColumns);
+ // check preCombine
+ final String preCombineField = conf.getString(FlinkOptions.PRECOMBINE_FIELD);
+ if (!resolvedSchema.getColumnNames().contains(preCombineField)) {
+ if (OptionsResolver.isDefaultHoodieRecordPayloadClazz(conf)) {
+ throw new HoodieValidationException("Option '" + FlinkOptions.PRECOMBINE_FIELD.key()
+ + "' is required for payload class: " + DefaultHoodieRecordPayload.class.getName());
+ }
+ if (preCombineField.equals(FlinkOptions.PRECOMBINE_FIELD.defaultValue())) {
+ conf.setString(FlinkOptions.PRECOMBINE_FIELD, FlinkOptions.NO_PRE_COMBINE);
+ } else if (!preCombineField.equals(FlinkOptions.NO_PRE_COMBINE)) {
+ throw new HoodieValidationException("Field " + preCombineField + " does not exist in the table schema."
+ + "Please check '" + FlinkOptions.PRECOMBINE_FIELD.key() + "' option.");
+ }
Review Comment:
Found duplicate code snippet in `HoodieTableFactory`, let's see wehter we can move that into a common utils. We can address that in another JIRA though ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1409843214
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455)
* 576dad186d2bfbe4bc497d75d17c6ded88df35a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1337063245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #7378:
URL: https://github.com/apache/hudi/pull/7378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1336859135
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1336864042
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1411547289
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 576dad186d2bfbe4bc497d75d17c6ded88df35a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801)
* f268edf5c55b638ffc382621ba34fbbc2fe697f5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1415719882
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
}, {
"hash" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895",
"triggerID" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a974f60952afa708af472ef6019b2ce8058d32d4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1410041788
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 576dad186d2bfbe4bc497d75d17c6ded88df35a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7378:
URL: https://github.com/apache/hudi/pull/7378#discussion_r1086317118
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalog.java:
##########
@@ -303,6 +306,21 @@ public void createTable(ObjectPath tablePath, CatalogBaseTable catalogTable, boo
options.put(TableOptionProperties.PK_CONSTRAINT_NAME, resolvedSchema.getPrimaryKey().get().getName());
options.put(TableOptionProperties.PK_COLUMNS, pkColumns);
+ // check preCombine
+ final String preCombineField = conf.getString(FlinkOptions.PRECOMBINE_FIELD);
+ if (!resolvedSchema.getColumnNames().contains(preCombineField)) {
+ if (OptionsResolver.isDefaultHoodieRecordPayloadClazz(conf)) {
+ throw new HoodieValidationException("Option '" + FlinkOptions.PRECOMBINE_FIELD.key()
+ + "' is required for payload class: " + DefaultHoodieRecordPayload.class.getName());
+ }
+ if (preCombineField.equals(FlinkOptions.PRECOMBINE_FIELD.defaultValue())) {
+ conf.setString(FlinkOptions.PRECOMBINE_FIELD, FlinkOptions.NO_PRE_COMBINE);
+ } else if (!preCombineField.equals(FlinkOptions.NO_PRE_COMBINE)) {
+ throw new HoodieValidationException("Field " + preCombineField + " does not exist in the table schema."
+ + "Please check '" + FlinkOptions.PRECOMBINE_FIELD.key() + "' option.");
+ }
Review Comment:
Found duplicate code snippet in `HoodieTableFactory`, let's see whether we can move that into a common utils. We can address that in another JIRA though ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1415332999
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
}, {
"hash" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f268edf5c55b638ffc382621ba34fbbc2fe697f5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836)
* a974f60952afa708af472ef6019b2ce8058d32d4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1411542578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 576dad186d2bfbe4bc497d75d17c6ded88df35a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801)
* f268edf5c55b638ffc382621ba34fbbc2fe697f5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1409849655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455)
* 576dad186d2bfbe4bc497d75d17c6ded88df35a5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1415288477
Still some errors, can you rebase with the latest master and force-push again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1416035212
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
}, {
"hash" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895",
"triggerID" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"triggerType" : "PUSH"
}, {
"hash" : "ce363216b67ac466c5a143d805159dc3a5bafc9a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14903",
"triggerID" : "ce363216b67ac466c5a143d805159dc3a5bafc9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce363216b67ac466c5a143d805159dc3a5bafc9a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7378: [HUDI-5329] spark reads hudi table error when flink creates the table without preCombine fields
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7378:
URL: https://github.com/apache/hudi/pull/7378#issuecomment-1415829477
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13455",
"triggerID" : "e6dd84eef8e98d43c19f31df2a88f6b1d3f6f717",
"triggerType" : "PUSH"
}, {
"hash" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14801",
"triggerID" : "576dad186d2bfbe4bc497d75d17c6ded88df35a5",
"triggerType" : "PUSH"
}, {
"hash" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14836",
"triggerID" : "f268edf5c55b638ffc382621ba34fbbc2fe697f5",
"triggerType" : "PUSH"
}, {
"hash" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895",
"triggerID" : "a974f60952afa708af472ef6019b2ce8058d32d4",
"triggerType" : "PUSH"
}, {
"hash" : "ce363216b67ac466c5a143d805159dc3a5bafc9a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14903",
"triggerID" : "ce363216b67ac466c5a143d805159dc3a5bafc9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a974f60952afa708af472ef6019b2ce8058d32d4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14895)
* ce363216b67ac466c5a143d805159dc3a5bafc9a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14903)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org