You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Mingmin Xu <mi...@gmail.com> on 2017/09/07 06:48:34 UTC
Merge branch DSL_SQL to master
Hi all,
On behalf of the virtual Beam SQL team[1], I'd like to propose to merge
DSL_SQL branch into master (PR #3782 [2]) and include it in release version
2.2.0, which will give it more visibility to other contributors and users.
The SQL feature satisfies the following criteria outlined in contribution
guide[3].
1. Have at least 2 contributors interested in maintaining it, and 1
committer interested in supporting it
* James and me will continue for new features and maintain it;
Tyler, James and me will support it as committers;
2. Provide both end-user and developer-facing documentation
* A web page[4] is added to describe the usage of SQL DSL and how it works;
3. Have at least a basic level of unit test coverage
* Totally 230 unit/integration tests, with code coverage 83.4%;
4. Run all existing applicable integration tests with other Beam components
and create additional tests as appropriate
* Besides of integration tests in package org.apache.beam.sdk.extensions.sql,
there's another example in org.apache.beam.sdk.extensions.sql.example.
BeamSqlExample.
[1]. Special thanks to all contributors/reviewers:
Tyler Akidau
Davor Bonaci
Robert Bradshaw
Lukasz Cwik
Tarush Grover
Kai Jiang
Kenneth Knowles
Jingsong Lee
Ismaël Mejía
Jean-Baptiste Onofré
James Xu
Mingmin Xu
[2]. https://github.com/apache/beam/pull/3782
[3]. https://beam.apache.org/contribute/contribution-guide/
#merging-into-master
[4]. https://beam.apache.org/documentation/dsls/sql/
Thanks!
----
Mingmin
Re: Merge branch DSL_SQL to master
Posted by James <xu...@gmail.com>.
+1. Glad to see it's coming finally.
On Thu, Sep 7, 2017 at 2:48 PM Mingmin Xu <mi...@gmail.com> wrote:
> Hi all,
>
> On behalf of the virtual Beam SQL team[1], I'd like to propose to merge
> DSL_SQL branch into master (PR #3782 [2]) and include it in release version
> 2.2.0, which will give it more visibility to other contributors and users.
> The SQL feature satisfies the following criteria outlined in contribution
> guide[3].
>
> 1. Have at least 2 contributors interested in maintaining it, and 1
> committer interested in supporting it
>
> * James and me will continue for new features and maintain it;
>
> Tyler, James and me will support it as committers;
>
> 2. Provide both end-user and developer-facing documentation
>
> * A web page[4] is added to describe the usage of SQL DSL and how it works;
>
>
> 3. Have at least a basic level of unit test coverage
>
> * Totally 230 unit/integration tests, with code coverage 83.4%;
>
> 4. Run all existing applicable integration tests with other Beam components
> and create additional tests as appropriate
>
> * Besides of integration tests in package
> org.apache.beam.sdk.extensions.sql,
> there's another example in org.apache.beam.sdk.extensions.sql.example.
> BeamSqlExample.
>
> [1]. Special thanks to all contributors/reviewers:
>
> Tyler Akidau
>
> Davor Bonaci
>
> Robert Bradshaw
>
> Lukasz Cwik
>
> Tarush Grover
>
> Kai Jiang
>
> Kenneth Knowles
>
> Jingsong Lee
>
> Ismaël Mejía
>
> Jean-Baptiste Onofré
>
> James Xu
>
> Mingmin Xu
>
> [2]. https://github.com/apache/beam/pull/3782
>
> [3]. https://beam.apache.org/contribute/contribution-guide/
> #merging-into-master
>
> [4]. https://beam.apache.org/documentation/dsls/sql/
>
> Thanks!
> ----
> Mingmin
>
Re: Merge branch DSL_SQL to master
Posted by Tyler Akidau <ta...@google.com.INVALID>.
Congrats, and thanks!
-Tyler
On Tue, Sep 12, 2017 at 5:49 AM Etienne Chauchot <ec...@gmail.com>
wrote:
> Great work guys!
>
> Etienne
>
>
> Le 11/09/2017 à 23:51, Mingmin Xu a écrit :
> > Now it's merged to master. Thanks to everyone!
> >
> > Mingmin
> >
> > On Thu, Sep 7, 2017 at 10:09 AM, Ahmet Altay <al...@google.com.invalid>
> > wrote:
> >
> >> +1 Thanks to all contributors/reviewers!
> >>
> >> On Thu, Sep 7, 2017 at 9:55 AM, Kai Jiang <ji...@gmail.com> wrote:
> >>
> >>> +1 looking forward to this.
> >>>
> >>> On Thu, Sep 7, 2017, 09:53 Tyler Akidau <ta...@google.com.invalid>
> >>> wrote:
> >>>
> >>>> +1, thanks for all the hard work to everyone that contributed!
> >>>>
> >>>> -Tyler
> >>>>
> >>>> On Thu, Sep 7, 2017 at 2:39 AM Ismaël Mejía <ie...@gmail.com>
> wrote:
> >>>>
> >>>>> +1
> >>>>> A nice feature to have on Beam. Great work guys !
> >>>>>
> >>>>> On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <pe...@gmail.com> wrote:
> >>>>>> +1
> >>>>>>
> >>>>>> On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <
> >>> tarushapptech@gmail.com
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Thank you all, it was a great learning experience!
> >>>>>>>
> >>>>>>> Regards,
> >>>>>>> Tarush
> >>>>>>>
> >>>>>>> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <
> >>> jb@nanthrax.net>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> +1
> >>>>>>>>
> >>>>>>>> Great work guys !
> >>>>>>>> Ready to help for the merge and maintain !
> >>>>>>>>
> >>>>>>>> Regards
> >>>>>>>> JB
> >>>>>>>>
> >>>>>>>> On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> >>>>>>>>> Hi all,
> >>>>>>>>>
> >>>>>>>>> On behalf of the virtual Beam SQL team[1], I'd like to propose
> >>> to
> >>>>> merge
> >>>>>>>>> DSL_SQL branch into master (PR #3782 [2]) and include it in
> >>>> release
> >>>>>>>> version
> >>>>>>>>> 2.2.0, which will give it more visibility to other
> >> contributors
> >>>> and
> >>>>>>>> users.
> >>>>>>>>> The SQL feature satisfies the following criteria outlined in
> >>>>>>> contribution
> >>>>>>>>> guide[3].
> >>>>>>>>>
> >>>>>>>>> 1. Have at least 2 contributors interested in maintaining it,
> >>> and
> >>>> 1
> >>>>>>>>> committer interested in supporting it
> >>>>>>>>>
> >>>>>>>>> * James and me will continue for new features and maintain it;
> >>>>>>>>>
> >>>>>>>>> Tyler, James and me will support it as committers;
> >>>>>>>>>
> >>>>>>>>> 2. Provide both end-user and developer-facing documentation
> >>>>>>>>>
> >>>>>>>>> * A web page[4] is added to describe the usage of SQL DSL and
> >>> how
> >>>> it
> >>>>>>>> works;
> >>>>>>>>>
> >>>>>>>>> 3. Have at least a basic level of unit test coverage
> >>>>>>>>>
> >>>>>>>>> * Totally 230 unit/integration tests, with code coverage
> >> 83.4%;
> >>>>>>>>> 4. Run all existing applicable integration tests with other
> >> Beam
> >>>>>>>> components
> >>>>>>>>> and create additional tests as appropriate
> >>>>>>>>>
> >>>>>>>>> * Besides of integration tests in package
> >>>>>>>> org.apache.beam.sdk.extensions.sql,
> >>>>>>>>> there's another example in
> >>>>> org.apache.beam.sdk.extensions.sql.example.
> >>>>>>>>> BeamSqlExample.
> >>>>>>>>>
> >>>>>>>>> [1]. Special thanks to all contributors/reviewers:
> >>>>>>>>>
> >>>>>>>>> Tyler Akidau
> >>>>>>>>>
> >>>>>>>>> Davor Bonaci
> >>>>>>>>>
> >>>>>>>>> Robert Bradshaw
> >>>>>>>>>
> >>>>>>>>> Lukasz Cwik
> >>>>>>>>>
> >>>>>>>>> Tarush Grover
> >>>>>>>>>
> >>>>>>>>> Kai Jiang
> >>>>>>>>>
> >>>>>>>>> Kenneth Knowles
> >>>>>>>>>
> >>>>>>>>> Jingsong Lee
> >>>>>>>>>
> >>>>>>>>> Ismaël Mejía
> >>>>>>>>>
> >>>>>>>>> Jean-Baptiste Onofré
> >>>>>>>>>
> >>>>>>>>> James Xu
> >>>>>>>>>
> >>>>>>>>> Mingmin Xu
> >>>>>>>>>
> >>>>>>>>> [2]. https://github.com/apache/beam/pull/3782
> >>>>>>>>>
> >>>>>>>>> [3]. https://beam.apache.org/contribute/contribution-guide/
> >>>>>>>>> #merging-into-master
> >>>>>>>>>
> >>>>>>>>> [4]. https://beam.apache.org/documentation/dsls/sql/
> >>>>>>>>>
> >>>>>>>>> Thanks!
> >>>>>>>>> ----
> >>>>>>>>> Mingmin
> >>>>>>>>>
> >>>>>>>> --
> >>>>>>>> Jean-Baptiste Onofré
> >>>>>>>> jbonofre@apache.org
> >>>>>>>> http://blog.nanthrax.net
> >>>>>>>> Talend - http://www.talend.com
> >>>>>>>>
> >
> >
>
>
Re: Merge branch DSL_SQL to master
Posted by Etienne Chauchot <ec...@gmail.com>.
Great work guys!
Etienne
Le 11/09/2017 à 23:51, Mingmin Xu a écrit :
> Now it's merged to master. Thanks to everyone!
>
> Mingmin
>
> On Thu, Sep 7, 2017 at 10:09 AM, Ahmet Altay <al...@google.com.invalid>
> wrote:
>
>> +1 Thanks to all contributors/reviewers!
>>
>> On Thu, Sep 7, 2017 at 9:55 AM, Kai Jiang <ji...@gmail.com> wrote:
>>
>>> +1 looking forward to this.
>>>
>>> On Thu, Sep 7, 2017, 09:53 Tyler Akidau <ta...@google.com.invalid>
>>> wrote:
>>>
>>>> +1, thanks for all the hard work to everyone that contributed!
>>>>
>>>> -Tyler
>>>>
>>>> On Thu, Sep 7, 2017 at 2:39 AM Ismaël Mejía <ie...@gmail.com> wrote:
>>>>
>>>>> +1
>>>>> A nice feature to have on Beam. Great work guys !
>>>>>
>>>>> On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <pe...@gmail.com> wrote:
>>>>>> +1
>>>>>>
>>>>>> On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <
>>> tarushapptech@gmail.com
>>>>>> wrote:
>>>>>>
>>>>>>> Thank you all, it was a great learning experience!
>>>>>>>
>>>>>>> Regards,
>>>>>>> Tarush
>>>>>>>
>>>>>>> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <
>>> jb@nanthrax.net>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> +1
>>>>>>>>
>>>>>>>> Great work guys !
>>>>>>>> Ready to help for the merge and maintain !
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> JB
>>>>>>>>
>>>>>>>> On 09/07/2017 08:48 AM, Mingmin Xu wrote:
>>>>>>>>> Hi all,
>>>>>>>>>
>>>>>>>>> On behalf of the virtual Beam SQL team[1], I'd like to propose
>>> to
>>>>> merge
>>>>>>>>> DSL_SQL branch into master (PR #3782 [2]) and include it in
>>>> release
>>>>>>>> version
>>>>>>>>> 2.2.0, which will give it more visibility to other
>> contributors
>>>> and
>>>>>>>> users.
>>>>>>>>> The SQL feature satisfies the following criteria outlined in
>>>>>>> contribution
>>>>>>>>> guide[3].
>>>>>>>>>
>>>>>>>>> 1. Have at least 2 contributors interested in maintaining it,
>>> and
>>>> 1
>>>>>>>>> committer interested in supporting it
>>>>>>>>>
>>>>>>>>> * James and me will continue for new features and maintain it;
>>>>>>>>>
>>>>>>>>> Tyler, James and me will support it as committers;
>>>>>>>>>
>>>>>>>>> 2. Provide both end-user and developer-facing documentation
>>>>>>>>>
>>>>>>>>> * A web page[4] is added to describe the usage of SQL DSL and
>>> how
>>>> it
>>>>>>>> works;
>>>>>>>>>
>>>>>>>>> 3. Have at least a basic level of unit test coverage
>>>>>>>>>
>>>>>>>>> * Totally 230 unit/integration tests, with code coverage
>> 83.4%;
>>>>>>>>> 4. Run all existing applicable integration tests with other
>> Beam
>>>>>>>> components
>>>>>>>>> and create additional tests as appropriate
>>>>>>>>>
>>>>>>>>> * Besides of integration tests in package
>>>>>>>> org.apache.beam.sdk.extensions.sql,
>>>>>>>>> there's another example in
>>>>> org.apache.beam.sdk.extensions.sql.example.
>>>>>>>>> BeamSqlExample.
>>>>>>>>>
>>>>>>>>> [1]. Special thanks to all contributors/reviewers:
>>>>>>>>>
>>>>>>>>> Tyler Akidau
>>>>>>>>>
>>>>>>>>> Davor Bonaci
>>>>>>>>>
>>>>>>>>> Robert Bradshaw
>>>>>>>>>
>>>>>>>>> Lukasz Cwik
>>>>>>>>>
>>>>>>>>> Tarush Grover
>>>>>>>>>
>>>>>>>>> Kai Jiang
>>>>>>>>>
>>>>>>>>> Kenneth Knowles
>>>>>>>>>
>>>>>>>>> Jingsong Lee
>>>>>>>>>
>>>>>>>>> Ismaël Mejía
>>>>>>>>>
>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>
>>>>>>>>> James Xu
>>>>>>>>>
>>>>>>>>> Mingmin Xu
>>>>>>>>>
>>>>>>>>> [2]. https://github.com/apache/beam/pull/3782
>>>>>>>>>
>>>>>>>>> [3]. https://beam.apache.org/contribute/contribution-guide/
>>>>>>>>> #merging-into-master
>>>>>>>>>
>>>>>>>>> [4]. https://beam.apache.org/documentation/dsls/sql/
>>>>>>>>>
>>>>>>>>> Thanks!
>>>>>>>>> ----
>>>>>>>>> Mingmin
>>>>>>>>>
>>>>>>>> --
>>>>>>>> Jean-Baptiste Onofré
>>>>>>>> jbonofre@apache.org
>>>>>>>> http://blog.nanthrax.net
>>>>>>>> Talend - http://www.talend.com
>>>>>>>>
>
>
Re: Merge branch DSL_SQL to master
Posted by Mingmin Xu <mi...@gmail.com>.
Now it's merged to master. Thanks to everyone!
Mingmin
On Thu, Sep 7, 2017 at 10:09 AM, Ahmet Altay <al...@google.com.invalid>
wrote:
> +1 Thanks to all contributors/reviewers!
>
> On Thu, Sep 7, 2017 at 9:55 AM, Kai Jiang <ji...@gmail.com> wrote:
>
> > +1 looking forward to this.
> >
> > On Thu, Sep 7, 2017, 09:53 Tyler Akidau <ta...@google.com.invalid>
> > wrote:
> >
> > > +1, thanks for all the hard work to everyone that contributed!
> > >
> > > -Tyler
> > >
> > > On Thu, Sep 7, 2017 at 2:39 AM Ismaël Mejía <ie...@gmail.com> wrote:
> > >
> > > > +1
> > > > A nice feature to have on Beam. Great work guys !
> > > >
> > > > On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <pe...@gmail.com> wrote:
> > > > > +1
> > > > >
> > > > > On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <
> > tarushapptech@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > >> Thank you all, it was a great learning experience!
> > > > >>
> > > > >> Regards,
> > > > >> Tarush
> > > > >>
> > > > >> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <
> > jb@nanthrax.net>
> > > > >> wrote:
> > > > >>
> > > > >> > +1
> > > > >> >
> > > > >> > Great work guys !
> > > > >> > Ready to help for the merge and maintain !
> > > > >> >
> > > > >> > Regards
> > > > >> > JB
> > > > >> >
> > > > >> > On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> > > > >> > > Hi all,
> > > > >> > >
> > > > >> > > On behalf of the virtual Beam SQL team[1], I'd like to propose
> > to
> > > > merge
> > > > >> > > DSL_SQL branch into master (PR #3782 [2]) and include it in
> > > release
> > > > >> > version
> > > > >> > > 2.2.0, which will give it more visibility to other
> contributors
> > > and
> > > > >> > users.
> > > > >> > > The SQL feature satisfies the following criteria outlined in
> > > > >> contribution
> > > > >> > > guide[3].
> > > > >> > >
> > > > >> > > 1. Have at least 2 contributors interested in maintaining it,
> > and
> > > 1
> > > > >> > > committer interested in supporting it
> > > > >> > >
> > > > >> > > * James and me will continue for new features and maintain it;
> > > > >> > >
> > > > >> > > Tyler, James and me will support it as committers;
> > > > >> > >
> > > > >> > > 2. Provide both end-user and developer-facing documentation
> > > > >> > >
> > > > >> > > * A web page[4] is added to describe the usage of SQL DSL and
> > how
> > > it
> > > > >> > works;
> > > > >> > >
> > > > >> > >
> > > > >> > > 3. Have at least a basic level of unit test coverage
> > > > >> > >
> > > > >> > > * Totally 230 unit/integration tests, with code coverage
> 83.4%;
> > > > >> > >
> > > > >> > > 4. Run all existing applicable integration tests with other
> Beam
> > > > >> > components
> > > > >> > > and create additional tests as appropriate
> > > > >> > >
> > > > >> > > * Besides of integration tests in package
> > > > >> > org.apache.beam.sdk.extensions.sql,
> > > > >> > > there's another example in
> > > > org.apache.beam.sdk.extensions.sql.example.
> > > > >> > > BeamSqlExample.
> > > > >> > >
> > > > >> > > [1]. Special thanks to all contributors/reviewers:
> > > > >> > >
> > > > >> > > Tyler Akidau
> > > > >> > >
> > > > >> > > Davor Bonaci
> > > > >> > >
> > > > >> > > Robert Bradshaw
> > > > >> > >
> > > > >> > > Lukasz Cwik
> > > > >> > >
> > > > >> > > Tarush Grover
> > > > >> > >
> > > > >> > > Kai Jiang
> > > > >> > >
> > > > >> > > Kenneth Knowles
> > > > >> > >
> > > > >> > > Jingsong Lee
> > > > >> > >
> > > > >> > > Ismaël Mejía
> > > > >> > >
> > > > >> > > Jean-Baptiste Onofré
> > > > >> > >
> > > > >> > > James Xu
> > > > >> > >
> > > > >> > > Mingmin Xu
> > > > >> > >
> > > > >> > > [2]. https://github.com/apache/beam/pull/3782
> > > > >> > >
> > > > >> > > [3]. https://beam.apache.org/contribute/contribution-guide/
> > > > >> > > #merging-into-master
> > > > >> > >
> > > > >> > > [4]. https://beam.apache.org/documentation/dsls/sql/
> > > > >> > >
> > > > >> > > Thanks!
> > > > >> > > ----
> > > > >> > > Mingmin
> > > > >> > >
> > > > >> >
> > > > >> > --
> > > > >> > Jean-Baptiste Onofré
> > > > >> > jbonofre@apache.org
> > > > >> > http://blog.nanthrax.net
> > > > >> > Talend - http://www.talend.com
> > > > >> >
> > > > >>
> > > >
> > >
> >
>
--
----
Mingmin
Re: Merge branch DSL_SQL to master
Posted by Ahmet Altay <al...@google.com.INVALID>.
+1 Thanks to all contributors/reviewers!
On Thu, Sep 7, 2017 at 9:55 AM, Kai Jiang <ji...@gmail.com> wrote:
> +1 looking forward to this.
>
> On Thu, Sep 7, 2017, 09:53 Tyler Akidau <ta...@google.com.invalid>
> wrote:
>
> > +1, thanks for all the hard work to everyone that contributed!
> >
> > -Tyler
> >
> > On Thu, Sep 7, 2017 at 2:39 AM Ismaël Mejía <ie...@gmail.com> wrote:
> >
> > > +1
> > > A nice feature to have on Beam. Great work guys !
> > >
> > > On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <pe...@gmail.com> wrote:
> > > > +1
> > > >
> > > > On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <
> tarushapptech@gmail.com
> > >
> > > > wrote:
> > > >
> > > >> Thank you all, it was a great learning experience!
> > > >>
> > > >> Regards,
> > > >> Tarush
> > > >>
> > > >> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <
> jb@nanthrax.net>
> > > >> wrote:
> > > >>
> > > >> > +1
> > > >> >
> > > >> > Great work guys !
> > > >> > Ready to help for the merge and maintain !
> > > >> >
> > > >> > Regards
> > > >> > JB
> > > >> >
> > > >> > On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> > > >> > > Hi all,
> > > >> > >
> > > >> > > On behalf of the virtual Beam SQL team[1], I'd like to propose
> to
> > > merge
> > > >> > > DSL_SQL branch into master (PR #3782 [2]) and include it in
> > release
> > > >> > version
> > > >> > > 2.2.0, which will give it more visibility to other contributors
> > and
> > > >> > users.
> > > >> > > The SQL feature satisfies the following criteria outlined in
> > > >> contribution
> > > >> > > guide[3].
> > > >> > >
> > > >> > > 1. Have at least 2 contributors interested in maintaining it,
> and
> > 1
> > > >> > > committer interested in supporting it
> > > >> > >
> > > >> > > * James and me will continue for new features and maintain it;
> > > >> > >
> > > >> > > Tyler, James and me will support it as committers;
> > > >> > >
> > > >> > > 2. Provide both end-user and developer-facing documentation
> > > >> > >
> > > >> > > * A web page[4] is added to describe the usage of SQL DSL and
> how
> > it
> > > >> > works;
> > > >> > >
> > > >> > >
> > > >> > > 3. Have at least a basic level of unit test coverage
> > > >> > >
> > > >> > > * Totally 230 unit/integration tests, with code coverage 83.4%;
> > > >> > >
> > > >> > > 4. Run all existing applicable integration tests with other Beam
> > > >> > components
> > > >> > > and create additional tests as appropriate
> > > >> > >
> > > >> > > * Besides of integration tests in package
> > > >> > org.apache.beam.sdk.extensions.sql,
> > > >> > > there's another example in
> > > org.apache.beam.sdk.extensions.sql.example.
> > > >> > > BeamSqlExample.
> > > >> > >
> > > >> > > [1]. Special thanks to all contributors/reviewers:
> > > >> > >
> > > >> > > Tyler Akidau
> > > >> > >
> > > >> > > Davor Bonaci
> > > >> > >
> > > >> > > Robert Bradshaw
> > > >> > >
> > > >> > > Lukasz Cwik
> > > >> > >
> > > >> > > Tarush Grover
> > > >> > >
> > > >> > > Kai Jiang
> > > >> > >
> > > >> > > Kenneth Knowles
> > > >> > >
> > > >> > > Jingsong Lee
> > > >> > >
> > > >> > > Ismaël Mejía
> > > >> > >
> > > >> > > Jean-Baptiste Onofré
> > > >> > >
> > > >> > > James Xu
> > > >> > >
> > > >> > > Mingmin Xu
> > > >> > >
> > > >> > > [2]. https://github.com/apache/beam/pull/3782
> > > >> > >
> > > >> > > [3]. https://beam.apache.org/contribute/contribution-guide/
> > > >> > > #merging-into-master
> > > >> > >
> > > >> > > [4]. https://beam.apache.org/documentation/dsls/sql/
> > > >> > >
> > > >> > > Thanks!
> > > >> > > ----
> > > >> > > Mingmin
> > > >> > >
> > > >> >
> > > >> > --
> > > >> > Jean-Baptiste Onofré
> > > >> > jbonofre@apache.org
> > > >> > http://blog.nanthrax.net
> > > >> > Talend - http://www.talend.com
> > > >> >
> > > >>
> > >
> >
>
Re: Merge branch DSL_SQL to master
Posted by Kai Jiang <ji...@gmail.com>.
+1 looking forward to this.
On Thu, Sep 7, 2017, 09:53 Tyler Akidau <ta...@google.com.invalid> wrote:
> +1, thanks for all the hard work to everyone that contributed!
>
> -Tyler
>
> On Thu, Sep 7, 2017 at 2:39 AM Ismaël Mejía <ie...@gmail.com> wrote:
>
> > +1
> > A nice feature to have on Beam. Great work guys !
> >
> > On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <pe...@gmail.com> wrote:
> > > +1
> > >
> > > On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <tarushapptech@gmail.com
> >
> > > wrote:
> > >
> > >> Thank you all, it was a great learning experience!
> > >>
> > >> Regards,
> > >> Tarush
> > >>
> > >> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > >> wrote:
> > >>
> > >> > +1
> > >> >
> > >> > Great work guys !
> > >> > Ready to help for the merge and maintain !
> > >> >
> > >> > Regards
> > >> > JB
> > >> >
> > >> > On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> > >> > > Hi all,
> > >> > >
> > >> > > On behalf of the virtual Beam SQL team[1], I'd like to propose to
> > merge
> > >> > > DSL_SQL branch into master (PR #3782 [2]) and include it in
> release
> > >> > version
> > >> > > 2.2.0, which will give it more visibility to other contributors
> and
> > >> > users.
> > >> > > The SQL feature satisfies the following criteria outlined in
> > >> contribution
> > >> > > guide[3].
> > >> > >
> > >> > > 1. Have at least 2 contributors interested in maintaining it, and
> 1
> > >> > > committer interested in supporting it
> > >> > >
> > >> > > * James and me will continue for new features and maintain it;
> > >> > >
> > >> > > Tyler, James and me will support it as committers;
> > >> > >
> > >> > > 2. Provide both end-user and developer-facing documentation
> > >> > >
> > >> > > * A web page[4] is added to describe the usage of SQL DSL and how
> it
> > >> > works;
> > >> > >
> > >> > >
> > >> > > 3. Have at least a basic level of unit test coverage
> > >> > >
> > >> > > * Totally 230 unit/integration tests, with code coverage 83.4%;
> > >> > >
> > >> > > 4. Run all existing applicable integration tests with other Beam
> > >> > components
> > >> > > and create additional tests as appropriate
> > >> > >
> > >> > > * Besides of integration tests in package
> > >> > org.apache.beam.sdk.extensions.sql,
> > >> > > there's another example in
> > org.apache.beam.sdk.extensions.sql.example.
> > >> > > BeamSqlExample.
> > >> > >
> > >> > > [1]. Special thanks to all contributors/reviewers:
> > >> > >
> > >> > > Tyler Akidau
> > >> > >
> > >> > > Davor Bonaci
> > >> > >
> > >> > > Robert Bradshaw
> > >> > >
> > >> > > Lukasz Cwik
> > >> > >
> > >> > > Tarush Grover
> > >> > >
> > >> > > Kai Jiang
> > >> > >
> > >> > > Kenneth Knowles
> > >> > >
> > >> > > Jingsong Lee
> > >> > >
> > >> > > Ismaël Mejía
> > >> > >
> > >> > > Jean-Baptiste Onofré
> > >> > >
> > >> > > James Xu
> > >> > >
> > >> > > Mingmin Xu
> > >> > >
> > >> > > [2]. https://github.com/apache/beam/pull/3782
> > >> > >
> > >> > > [3]. https://beam.apache.org/contribute/contribution-guide/
> > >> > > #merging-into-master
> > >> > >
> > >> > > [4]. https://beam.apache.org/documentation/dsls/sql/
> > >> > >
> > >> > > Thanks!
> > >> > > ----
> > >> > > Mingmin
> > >> > >
> > >> >
> > >> > --
> > >> > Jean-Baptiste Onofré
> > >> > jbonofre@apache.org
> > >> > http://blog.nanthrax.net
> > >> > Talend - http://www.talend.com
> > >> >
> > >>
> >
>
Re: Merge branch DSL_SQL to master
Posted by Tyler Akidau <ta...@google.com.INVALID>.
+1, thanks for all the hard work to everyone that contributed!
-Tyler
On Thu, Sep 7, 2017 at 2:39 AM Ismaël Mejía <ie...@gmail.com> wrote:
> +1
> A nice feature to have on Beam. Great work guys !
>
> On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <pe...@gmail.com> wrote:
> > +1
> >
> > On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <ta...@gmail.com>
> > wrote:
> >
> >> Thank you all, it was a great learning experience!
> >>
> >> Regards,
> >> Tarush
> >>
> >> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> >> wrote:
> >>
> >> > +1
> >> >
> >> > Great work guys !
> >> > Ready to help for the merge and maintain !
> >> >
> >> > Regards
> >> > JB
> >> >
> >> > On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> >> > > Hi all,
> >> > >
> >> > > On behalf of the virtual Beam SQL team[1], I'd like to propose to
> merge
> >> > > DSL_SQL branch into master (PR #3782 [2]) and include it in release
> >> > version
> >> > > 2.2.0, which will give it more visibility to other contributors and
> >> > users.
> >> > > The SQL feature satisfies the following criteria outlined in
> >> contribution
> >> > > guide[3].
> >> > >
> >> > > 1. Have at least 2 contributors interested in maintaining it, and 1
> >> > > committer interested in supporting it
> >> > >
> >> > > * James and me will continue for new features and maintain it;
> >> > >
> >> > > Tyler, James and me will support it as committers;
> >> > >
> >> > > 2. Provide both end-user and developer-facing documentation
> >> > >
> >> > > * A web page[4] is added to describe the usage of SQL DSL and how it
> >> > works;
> >> > >
> >> > >
> >> > > 3. Have at least a basic level of unit test coverage
> >> > >
> >> > > * Totally 230 unit/integration tests, with code coverage 83.4%;
> >> > >
> >> > > 4. Run all existing applicable integration tests with other Beam
> >> > components
> >> > > and create additional tests as appropriate
> >> > >
> >> > > * Besides of integration tests in package
> >> > org.apache.beam.sdk.extensions.sql,
> >> > > there's another example in
> org.apache.beam.sdk.extensions.sql.example.
> >> > > BeamSqlExample.
> >> > >
> >> > > [1]. Special thanks to all contributors/reviewers:
> >> > >
> >> > > Tyler Akidau
> >> > >
> >> > > Davor Bonaci
> >> > >
> >> > > Robert Bradshaw
> >> > >
> >> > > Lukasz Cwik
> >> > >
> >> > > Tarush Grover
> >> > >
> >> > > Kai Jiang
> >> > >
> >> > > Kenneth Knowles
> >> > >
> >> > > Jingsong Lee
> >> > >
> >> > > Ismaël Mejía
> >> > >
> >> > > Jean-Baptiste Onofré
> >> > >
> >> > > James Xu
> >> > >
> >> > > Mingmin Xu
> >> > >
> >> > > [2]. https://github.com/apache/beam/pull/3782
> >> > >
> >> > > [3]. https://beam.apache.org/contribute/contribution-guide/
> >> > > #merging-into-master
> >> > >
> >> > > [4]. https://beam.apache.org/documentation/dsls/sql/
> >> > >
> >> > > Thanks!
> >> > > ----
> >> > > Mingmin
> >> > >
> >> >
> >> > --
> >> > Jean-Baptiste Onofré
> >> > jbonofre@apache.org
> >> > http://blog.nanthrax.net
> >> > Talend - http://www.talend.com
> >> >
> >>
>
Re: Merge branch DSL_SQL to master
Posted by Ismaël Mejía <ie...@gmail.com>.
+1
A nice feature to have on Beam. Great work guys !
On Thu, Sep 7, 2017 at 10:21 AM, Pei HE <pe...@gmail.com> wrote:
> +1
>
> On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <ta...@gmail.com>
> wrote:
>
>> Thank you all, it was a great learning experience!
>>
>> Regards,
>> Tarush
>>
>> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <jb...@nanthrax.net>
>> wrote:
>>
>> > +1
>> >
>> > Great work guys !
>> > Ready to help for the merge and maintain !
>> >
>> > Regards
>> > JB
>> >
>> > On 09/07/2017 08:48 AM, Mingmin Xu wrote:
>> > > Hi all,
>> > >
>> > > On behalf of the virtual Beam SQL team[1], I'd like to propose to merge
>> > > DSL_SQL branch into master (PR #3782 [2]) and include it in release
>> > version
>> > > 2.2.0, which will give it more visibility to other contributors and
>> > users.
>> > > The SQL feature satisfies the following criteria outlined in
>> contribution
>> > > guide[3].
>> > >
>> > > 1. Have at least 2 contributors interested in maintaining it, and 1
>> > > committer interested in supporting it
>> > >
>> > > * James and me will continue for new features and maintain it;
>> > >
>> > > Tyler, James and me will support it as committers;
>> > >
>> > > 2. Provide both end-user and developer-facing documentation
>> > >
>> > > * A web page[4] is added to describe the usage of SQL DSL and how it
>> > works;
>> > >
>> > >
>> > > 3. Have at least a basic level of unit test coverage
>> > >
>> > > * Totally 230 unit/integration tests, with code coverage 83.4%;
>> > >
>> > > 4. Run all existing applicable integration tests with other Beam
>> > components
>> > > and create additional tests as appropriate
>> > >
>> > > * Besides of integration tests in package
>> > org.apache.beam.sdk.extensions.sql,
>> > > there's another example in org.apache.beam.sdk.extensions.sql.example.
>> > > BeamSqlExample.
>> > >
>> > > [1]. Special thanks to all contributors/reviewers:
>> > >
>> > > Tyler Akidau
>> > >
>> > > Davor Bonaci
>> > >
>> > > Robert Bradshaw
>> > >
>> > > Lukasz Cwik
>> > >
>> > > Tarush Grover
>> > >
>> > > Kai Jiang
>> > >
>> > > Kenneth Knowles
>> > >
>> > > Jingsong Lee
>> > >
>> > > Ismaël Mejía
>> > >
>> > > Jean-Baptiste Onofré
>> > >
>> > > James Xu
>> > >
>> > > Mingmin Xu
>> > >
>> > > [2]. https://github.com/apache/beam/pull/3782
>> > >
>> > > [3]. https://beam.apache.org/contribute/contribution-guide/
>> > > #merging-into-master
>> > >
>> > > [4]. https://beam.apache.org/documentation/dsls/sql/
>> > >
>> > > Thanks!
>> > > ----
>> > > Mingmin
>> > >
>> >
>> > --
>> > Jean-Baptiste Onofré
>> > jbonofre@apache.org
>> > http://blog.nanthrax.net
>> > Talend - http://www.talend.com
>> >
>>
Re: Merge branch DSL_SQL to master
Posted by Pei HE <pe...@gmail.com>.
+1
On Thu, Sep 7, 2017 at 4:03 PM, tarush grover <ta...@gmail.com>
wrote:
> Thank you all, it was a great learning experience!
>
> Regards,
> Tarush
>
> On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
> > +1
> >
> > Great work guys !
> > Ready to help for the merge and maintain !
> >
> > Regards
> > JB
> >
> > On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> > > Hi all,
> > >
> > > On behalf of the virtual Beam SQL team[1], I'd like to propose to merge
> > > DSL_SQL branch into master (PR #3782 [2]) and include it in release
> > version
> > > 2.2.0, which will give it more visibility to other contributors and
> > users.
> > > The SQL feature satisfies the following criteria outlined in
> contribution
> > > guide[3].
> > >
> > > 1. Have at least 2 contributors interested in maintaining it, and 1
> > > committer interested in supporting it
> > >
> > > * James and me will continue for new features and maintain it;
> > >
> > > Tyler, James and me will support it as committers;
> > >
> > > 2. Provide both end-user and developer-facing documentation
> > >
> > > * A web page[4] is added to describe the usage of SQL DSL and how it
> > works;
> > >
> > >
> > > 3. Have at least a basic level of unit test coverage
> > >
> > > * Totally 230 unit/integration tests, with code coverage 83.4%;
> > >
> > > 4. Run all existing applicable integration tests with other Beam
> > components
> > > and create additional tests as appropriate
> > >
> > > * Besides of integration tests in package
> > org.apache.beam.sdk.extensions.sql,
> > > there's another example in org.apache.beam.sdk.extensions.sql.example.
> > > BeamSqlExample.
> > >
> > > [1]. Special thanks to all contributors/reviewers:
> > >
> > > Tyler Akidau
> > >
> > > Davor Bonaci
> > >
> > > Robert Bradshaw
> > >
> > > Lukasz Cwik
> > >
> > > Tarush Grover
> > >
> > > Kai Jiang
> > >
> > > Kenneth Knowles
> > >
> > > Jingsong Lee
> > >
> > > Ismaël Mejía
> > >
> > > Jean-Baptiste Onofré
> > >
> > > James Xu
> > >
> > > Mingmin Xu
> > >
> > > [2]. https://github.com/apache/beam/pull/3782
> > >
> > > [3]. https://beam.apache.org/contribute/contribution-guide/
> > > #merging-into-master
> > >
> > > [4]. https://beam.apache.org/documentation/dsls/sql/
> > >
> > > Thanks!
> > > ----
> > > Mingmin
> > >
> >
> > --
> > Jean-Baptiste Onofré
> > jbonofre@apache.org
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
> >
>
Re: Merge branch DSL_SQL to master
Posted by tarush grover <ta...@gmail.com>.
Thank you all, it was a great learning experience!
Regards,
Tarush
On Thu, 7 Sep 2017 at 1:05 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> +1
>
> Great work guys !
> Ready to help for the merge and maintain !
>
> Regards
> JB
>
> On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> > Hi all,
> >
> > On behalf of the virtual Beam SQL team[1], I'd like to propose to merge
> > DSL_SQL branch into master (PR #3782 [2]) and include it in release
> version
> > 2.2.0, which will give it more visibility to other contributors and
> users.
> > The SQL feature satisfies the following criteria outlined in contribution
> > guide[3].
> >
> > 1. Have at least 2 contributors interested in maintaining it, and 1
> > committer interested in supporting it
> >
> > * James and me will continue for new features and maintain it;
> >
> > Tyler, James and me will support it as committers;
> >
> > 2. Provide both end-user and developer-facing documentation
> >
> > * A web page[4] is added to describe the usage of SQL DSL and how it
> works;
> >
> >
> > 3. Have at least a basic level of unit test coverage
> >
> > * Totally 230 unit/integration tests, with code coverage 83.4%;
> >
> > 4. Run all existing applicable integration tests with other Beam
> components
> > and create additional tests as appropriate
> >
> > * Besides of integration tests in package
> org.apache.beam.sdk.extensions.sql,
> > there's another example in org.apache.beam.sdk.extensions.sql.example.
> > BeamSqlExample.
> >
> > [1]. Special thanks to all contributors/reviewers:
> >
> > Tyler Akidau
> >
> > Davor Bonaci
> >
> > Robert Bradshaw
> >
> > Lukasz Cwik
> >
> > Tarush Grover
> >
> > Kai Jiang
> >
> > Kenneth Knowles
> >
> > Jingsong Lee
> >
> > Ismaël Mejía
> >
> > Jean-Baptiste Onofré
> >
> > James Xu
> >
> > Mingmin Xu
> >
> > [2]. https://github.com/apache/beam/pull/3782
> >
> > [3]. https://beam.apache.org/contribute/contribution-guide/
> > #merging-into-master
> >
> > [4]. https://beam.apache.org/documentation/dsls/sql/
> >
> > Thanks!
> > ----
> > Mingmin
> >
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
Re: Merge branch DSL_SQL to master
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1
Great work guys !
Ready to help for the merge and maintain !
Regards
JB
On 09/07/2017 08:48 AM, Mingmin Xu wrote:
> Hi all,
>
> On behalf of the virtual Beam SQL team[1], I'd like to propose to merge
> DSL_SQL branch into master (PR #3782 [2]) and include it in release version
> 2.2.0, which will give it more visibility to other contributors and users.
> The SQL feature satisfies the following criteria outlined in contribution
> guide[3].
>
> 1. Have at least 2 contributors interested in maintaining it, and 1
> committer interested in supporting it
>
> * James and me will continue for new features and maintain it;
>
> Tyler, James and me will support it as committers;
>
> 2. Provide both end-user and developer-facing documentation
>
> * A web page[4] is added to describe the usage of SQL DSL and how it works;
>
>
> 3. Have at least a basic level of unit test coverage
>
> * Totally 230 unit/integration tests, with code coverage 83.4%;
>
> 4. Run all existing applicable integration tests with other Beam components
> and create additional tests as appropriate
>
> * Besides of integration tests in package org.apache.beam.sdk.extensions.sql,
> there's another example in org.apache.beam.sdk.extensions.sql.example.
> BeamSqlExample.
>
> [1]. Special thanks to all contributors/reviewers:
>
> Tyler Akidau
>
> Davor Bonaci
>
> Robert Bradshaw
>
> Lukasz Cwik
>
> Tarush Grover
>
> Kai Jiang
>
> Kenneth Knowles
>
> Jingsong Lee
>
> Ismaël Mejía
>
> Jean-Baptiste Onofré
>
> James Xu
>
> Mingmin Xu
>
> [2]. https://github.com/apache/beam/pull/3782
>
> [3]. https://beam.apache.org/contribute/contribution-guide/
> #merging-into-master
>
> [4]. https://beam.apache.org/documentation/dsls/sql/
>
> Thanks!
> ----
> Mingmin
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com