You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2015/04/06 17:13:50 UTC
[GitHub] thrift pull request: Bugfix/thrift 3081 consolidate client process...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/428
Bugfix/thrift 3081 consolidate client processing loops
The pull request consolidates the client processing loop contained within TSimpleServer, TThreadedServer, TThreadPoolServer that were all similar but not functionally identical. This will improve maintainability.
This pull request and the open one for THRIFT-2441 will collide slightly. Whichever one gets pulled in first, I will update the other...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3081-consolidate-client-processing-loops
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/428.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #428
----
commit 44713020d03c38776432642d0798ea8d9f3e4168
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-05T16:32:03Z
[THRIFT-3081] consolidate C++ client processing loops
commit 3cc72ce101f2214b5b9698473523a93820219388
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-06T15:10:50Z
Merge branch 'master' of https://github.com/apache/thrift into bugfix/THRIFT-3081-consolidate-client-processing-loops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/428#issuecomment-91284246
There was no conflict with master however I need to base THRIFT-3083 on top of these changes so I needed to refresh it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/428#issuecomment-91361228
Build failed though no fault of my own, so closing this and opening a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---