You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/02/03 22:03:02 UTC
Review Request 30577: Adding new host after version distribution does
not contain 2 host versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30577/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
Bugs: AMBARI-9464
https://issues.apache.org/jira/browse/AMBARI-9464
Repository: ambari
Description
-------
Install HDP-2.2.0.0 and then register a HDP-2.2.1.0 version. Click on install and finish installing the version. Then add a new host selecting all the components you can select. The new host's Versions page has only 1 row having the old version.
It should have 2 rows - one for the old version and one for the new version. Old versions button should be disabled while the new versions button should be enabled. Clicking on the new version button should install the new components there.
Also, the admin-versions page should have action to install as opposed to perform-upgrade.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java c2748df
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 4d8f3be
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/30577/diff/
Testing
-------
unit test run
Thanks,
Dmitro Lisnichenko
Re: Review Request 30577: Adding new host after version distribution
does not contain 2 host versions
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30577/#review70937
-----------------------------------------------------------
Ship it!
Ship It!
- Yurii Shylov
On Фев. 4, 2015, 9:44 д.п., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30577/
> -----------------------------------------------------------
>
> (Updated Фев. 4, 2015, 9:44 д.п.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
>
>
> Bugs: AMBARI-9464
> https://issues.apache.org/jira/browse/AMBARI-9464
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Install HDP-2.2.0.0 and then register a HDP-2.2.1.0 version. Click on install and finish installing the version. Then add a new host selecting all the components you can select. The new host's Versions page has only 1 row having the old version.
> It should have 2 rows - one for the old version and one for the new version. Old versions button should be disabled while the new versions button should be enabled. Clicking on the new version button should install the new components there.
> Also, the admin-versions page should have action to install as opposed to perform-upgrade.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java c2748df
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 4d8f3be
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30577/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [3.073s]
> [INFO] Ambari Server ..................................... SUCCESS [30:42.560s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.210s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:01.451s
> [INFO] Finished at: Wed Feb 04 00:36:17 FET 2015
> [INFO] Final Memory: 37M/222M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 30577: Adding new host after version distribution
does not contain 2 host versions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30577/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 9:44 a.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
Changes
-------
Added comment and attached mvn clean test result
Bugs: AMBARI-9464
https://issues.apache.org/jira/browse/AMBARI-9464
Repository: ambari
Description
-------
Install HDP-2.2.0.0 and then register a HDP-2.2.1.0 version. Click on install and finish installing the version. Then add a new host selecting all the components you can select. The new host's Versions page has only 1 row having the old version.
It should have 2 rows - one for the old version and one for the new version. Old versions button should be disabled while the new versions button should be enabled. Clicking on the new version button should install the new components there.
Also, the admin-versions page should have action to install as opposed to perform-upgrade.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java c2748df
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 4d8f3be
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/30577/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.073s]
[INFO] Ambari Server ..................................... SUCCESS [30:42.560s]
[INFO] Ambari Agent ...................................... SUCCESS [15.210s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:01.451s
[INFO] Finished at: Wed Feb 04 00:36:17 FET 2015
[INFO] Final Memory: 37M/222M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 30577: Adding new host after version distribution
does not contain 2 host versions
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Feb. 3, 2015, 9:21 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java, line 145
> > <https://reviews.apache.org/r/30577/diff/1/?file=846540#file846540line145>
> >
> > Technically, this should only be if the state is in [INSTALLING, INSTALL_FAILED, INSTALLED], because the other states [UPGRADING, UPGRADE_FAILED, UPGRADED] are handled once the host heartbeats
On second thought, your method is more strict, since adding a host while the upgrade is in progress should also be out_of_sync. The implications are complicated because while the actual rolling upgrade is in progress, the user can only continue or downgrade, but cannot re-distribute bits.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30577/#review70831
-----------------------------------------------------------
On Feb. 3, 2015, 9:03 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30577/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 9:03 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
>
>
> Bugs: AMBARI-9464
> https://issues.apache.org/jira/browse/AMBARI-9464
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Install HDP-2.2.0.0 and then register a HDP-2.2.1.0 version. Click on install and finish installing the version. Then add a new host selecting all the components you can select. The new host's Versions page has only 1 row having the old version.
> It should have 2 rows - one for the old version and one for the new version. Old versions button should be disabled while the new versions button should be enabled. Clicking on the new version button should install the new components there.
> Also, the admin-versions page should have action to install as opposed to perform-upgrade.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java c2748df
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 4d8f3be
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30577/diff/
>
>
> Testing
> -------
>
> unit test run
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 30577: Adding new host after version distribution
does not contain 2 host versions
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30577/#review70831
-----------------------------------------------------------
Ship it!
Fix it, then ship it.
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
<https://reviews.apache.org/r/30577/#comment116274>
Technically, this should only be if the state is in [INSTALLING, INSTALL_FAILED, INSTALLED], because the other states [UPGRADING, UPGRADE_FAILED, UPGRADED] are handled once the host heartbeats
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
<https://reviews.apache.org/r/30577/#comment116273>
Please add a Java comment indicating the precise test. E.g.,
"When a host is added to a cluster that has cluster_version records in INSTALLING, INSTALL_FAILED, or INSTALLED, then Ambari needs to insert host_verion record for each one of those stack versions with a state of OUT_OF_SYNC.
- Alejandro Fernandez
On Feb. 3, 2015, 9:03 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30577/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 9:03 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
>
>
> Bugs: AMBARI-9464
> https://issues.apache.org/jira/browse/AMBARI-9464
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Install HDP-2.2.0.0 and then register a HDP-2.2.1.0 version. Click on install and finish installing the version. Then add a new host selecting all the components you can select. The new host's Versions page has only 1 row having the old version.
> It should have 2 rows - one for the old version and one for the new version. Old versions button should be disabled while the new versions button should be enabled. Clicking on the new version button should install the new components there.
> Also, the admin-versions page should have action to install as opposed to perform-upgrade.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java c2748df
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 4d8f3be
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30577/diff/
>
>
> Testing
> -------
>
> unit test run
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>