[GitHub] [pulsar] codelipenghui commented on a change in pull request #7552: [Transaction] Produce transaction messages and commit

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #7552:
URL: https://github.com/apache/pulsar/pull/7552#discussion_r461603349



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1212,6 +1221,33 @@ protected void handleSend(CommandSend send, ByteBuf headersAndPayload) {
 
         startSendOperation(producer, headersAndPayload.readableBytes(), send.getNumMessages());
 
+        final long produceId = producer.getProducerId();

Review comment:
       It's better to handle the transaction message in the topic, not the server cnx. 

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -549,6 +552,9 @@ public Boolean get() {
                 transactionMetadataStoreService = new TransactionMetadataStoreService(TransactionMetadataStoreProvider
                         .newProvider(config.getTransactionMetadataStoreProviderClassName()), this);
                 transactionMetadataStoreService.start();
+
+                transactionBufferProvider = TransactionBufferProvider.newProvider(
+                        PersistentTransactionBufferProvider.class.getName());

Review comment:
       It's better to config in the broker.conf.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org