You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2025/11/04 22:32:08 UTC
[PR] GH-47722: [C++][FlightRPC] WIP: ODBC Data Type Information [arrow]
alinaliBQ opened a new pull request, #48051:
URL: https://github.com/apache/arrow/pull/48051
### Rationale for this change
Implement ODBC to return information about data types supported by the data source
### What changes are included in this PR?
- SQLGetTypeInfo & Tests
### Are these changes tested?
Tested locally on MSVC
### Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47722: [C++][FlightRPC] ODBC Data Type Information [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #48051:
URL: https://github.com/apache/arrow/pull/48051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47722: [C++][FlightRPC] WIP: ODBC Data Type Information [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48051:
URL: https://github.com/apache/arrow/pull/48051#issuecomment-3488238050
:warning: GitHub issue #47722 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47722: [C++][FlightRPC] WIP: ODBC Data Type Information [arrow]
Posted by "justing-bq (via GitHub)" <gi...@apache.org>.
justing-bq commented on code in PR #48051:
URL: https://github.com/apache/arrow/pull/48051#discussion_r2496672199
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/util.cc:
##########
@@ -926,9 +934,9 @@ ArrayConvertTask GetConverter(Type::type original_type_id, CDataType target_type
auto seconds_from_epoch = GetTodayTimeFromEpoch();
- auto third_converted_array = CheckConversion(
- arrow::compute::Add(second_converted_array,
- std::make_shared<Int64Scalar>(seconds_from_epoch * 1000)));
+ auto third_converted_array = CheckConversion(arrow::compute::Add(
+ second_converted_array,
+ std::make_shared<arrow::Int64Scalar>(seconds_from_epoch * 1000)));
Review Comment:
Why are we adding `arrow::` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47722: [C++][FlightRPC] WIP: ODBC Data Type Information [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #48051:
URL: https://github.com/apache/arrow/pull/48051#discussion_r2501309485
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/util.cc:
##########
@@ -926,9 +934,9 @@ ArrayConvertTask GetConverter(Type::type original_type_id, CDataType target_type
auto seconds_from_epoch = GetTodayTimeFromEpoch();
- auto third_converted_array = CheckConversion(
- arrow::compute::Add(second_converted_array,
- std::make_shared<Int64Scalar>(seconds_from_epoch * 1000)));
+ auto third_converted_array = CheckConversion(arrow::compute::Add(
+ second_converted_array,
+ std::make_shared<arrow::Int64Scalar>(seconds_from_epoch * 1000)));
Review Comment:
Removed `arrow::` here as it is optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47722: [C++][FlightRPC] ODBC Data Type Information [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #48051:
URL: https://github.com/apache/arrow/pull/48051#issuecomment-3523278331
@lidavidm this draft PR is ready for review! Please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47722: [C++][FlightRPC] ODBC Data Type Information [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48051:
URL: https://github.com/apache/arrow/pull/48051#issuecomment-3699452936
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0c694e78331687e838c74d0d0aa73af350bdb66a.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/59157806396) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org