You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chukwa.apache.org by "Eric Yang (JIRA)" <ji...@apache.org> on 2009/04/12 20:12:15 UTC

[jira] Created: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Metrics Data Loader doesn't close connection when data loading is finished.
---------------------------------------------------------------------------

                 Key: CHUKWA-124
                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
             Project: Hadoop Chukwa
          Issue Type: Bug
          Components: Data Processors
    Affects Versions: 0.1.2
         Environment: Redhat EL 5.1, Java 6
            Reporter: Eric Yang
             Fix For: 0.1.2


PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Cheng (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698487#action_12698487 ] 

Cheng commented on CHUKWA-124:
------------------------------

The commit statement is in the finally block. Shall it be in the try block? If we leave it in the finally block, we should catch the exception. Otherwise if something is wrong with the commit, the close statements will never get called.

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated CHUKWA-124:
-----------------------------

    Attachment:     (was: CHUKWA-124.patch)

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated CHUKWA-124:
-----------------------------

    Attachment: CHUKWA-124.patch

Close database connection at end of the process.

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated CHUKWA-124:
-----------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.  Thanks Cheng.

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124-1.patch, CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang reassigned CHUKWA-124:
--------------------------------

    Assignee: Eric Yang

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated CHUKWA-124:
-----------------------------

    Status: Patch Available  (was: Open)

Changed JDBC connection to create on demand and close connection when database loading is completed.


> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated CHUKWA-124:
-----------------------------

    Priority: Blocker  (was: Major)

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated CHUKWA-124:
-----------------------------

    Attachment: CHUKWA-124.patch

Initialize JDBC on demand

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated CHUKWA-124:
-----------------------------

    Attachment: CHUKWA-124-1.patch

Added try and catch around commit.

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124-1.patch, CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CHUKWA-124) Metrics Data Loader doesn't close connection when data loading is finished.

Posted by "Cheng (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHUKWA-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698522#action_12698522 ] 

Cheng commented on CHUKWA-124:
------------------------------

+1 

> Metrics Data Loader doesn't close connection when data loading is finished.
> ---------------------------------------------------------------------------
>
>                 Key: CHUKWA-124
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-124
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: Data Processors
>    Affects Versions: 0.1.2
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.1.2
>
>         Attachments: CHUKWA-124-1.patch, CHUKWA-124.patch
>
>
> PostProcessManager is running as a deamon now, and jdbc connection without closing becomes a serious issue.  Database loader needs to close the connection when sequence file is finished loading to the database.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.