You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Michi Mutsuzaki (JIRA)" <ji...@apache.org> on 2013/12/14 00:47:07 UTC

[jira] [Commented] (ZOOKEEPER-1715) Upgrade netty version

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848070#comment-13848070 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1715:
--------------------------------------------

The timeout issue is fixed with this patch, but I got some failures:

{noformat}
Testcase: testDisconnectedAddAuth took 121.339 sec
        FAILED
waiting for server being up
junit.framework.AssertionFailedError: waiting for server being up
        at org.apache.zookeeper.test.ACLTest.testDisconnectedAddAuth(ACLTest.java:63)
        at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
Testcase: testSessionTimeout took 134.221 sec
        FAILED
waiting for server up
junit.framework.AssertionFailedError: waiting for server up
        at org.apache.zookeeper.test.SessionTest.setUp(SessionTest.java:80)
        at org.apache.zookeeper.test.SessionTest.testSessionTimeout(SessionTest.java:293)
        at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

Testcase: testWatcherAutoResetWithLocal took 123.392 sec 
        FAILED
waiting for server up
junit.framework.AssertionFailedError: waiting for server up
        at org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
        at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
        at org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:341)
        at org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithLocal(WatcherTest.java:242)
        at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

        FAILED
expected:<0> but was:<2>
junit.framework.AssertionFailedError: expected:<0> but was:<2>
        at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
        at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
        at org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)

Testcase: testWatcherAutoResetDisabledWithGlobal took 3.16 sec
        FAILED
expected:<0> but was:<2>
junit.framework.AssertionFailedError: expected:<0> but was:<2>
        at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
        at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
        at org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:278)
        at org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithGlobal(WatcherTest.java:233)
        at org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithGlobal(WatcherTest.java:249)
        at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
        
        FAILED
expected:<0> but was:<2>
junit.framework.AssertionFailedError: expected:<0> but was:<2>
        at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
        at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
        at org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
        
Testcase: testWatcherAutoResetDisabledWithLocal took 120.027 sec
        FAILED
waiting for server up
junit.framework.AssertionFailedError: waiting for server up
        at org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
        at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
        at org.apache.zookeeper.test.ClientBase.setUp(ClientBase.java:408)
        at org.apache.zookeeper.test.WatcherTest.setUp(WatcherTest.java:74)

        FAILED
expected:<0> but was:<2>
junit.framework.AssertionFailedError: expected:<0> but was:<2>
        at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
        at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
        at org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
{noformat}

> Upgrade netty version
> ---------------------
>
>                 Key: ZOOKEEPER-1715
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1715
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.5
>         Environment: zookeeper 3.4.5 uses netty 3.2.2, which was released in August 2010.  The latest version of netty is 3.6.6 released May 2013.  Zookeeper should consider upgrading.
>            Reporter: Sean Bridges
>            Assignee: Sean Bridges
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1715-2.patch, ZOOKEEPER-1715-v3.patch, ZOOKEEPER-1715.patch, zookeeper-1715.patch
>
>
> Upgrade netty version



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: [jira] [Commented] (ZOOKEEPER-1715) Upgrade netty version

Posted by Michi Mutsuzaki <mi...@cs.stanford.edu>.
Ok thanks German. I'll backport ZOOKEEPER-1715 to 3.4 and then check
in ZOOKEEPER-1837. I just saw you updated the patch to address
Flavio's comment.

On Fri, Dec 13, 2013 at 10:11 PM, German Blanco
<ge...@gmail.com> wrote:
> The JMXEnv.ensureOnly assertions are covered in ZOOKEEPER-1837.
> Still investigating the issue though.
>
>
> On Sat, Dec 14, 2013 at 12:47 AM, Michi Mutsuzaki (JIRA) <ji...@apache.org>wrote:
>
>>
>>     [
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848070#comment-13848070]
>>
>> Michi Mutsuzaki commented on ZOOKEEPER-1715:
>> --------------------------------------------
>>
>> The timeout issue is fixed with this patch, but I got some failures:
>>
>> {noformat}
>> Testcase: testDisconnectedAddAuth took 121.339 sec
>>         FAILED
>> waiting for server being up
>> junit.framework.AssertionFailedError: waiting for server being up
>>         at
>> org.apache.zookeeper.test.ACLTest.testDisconnectedAddAuth(ACLTest.java:63)
>>         at
>> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
>> Testcase: testSessionTimeout took 134.221 sec
>>         FAILED
>> waiting for server up
>> junit.framework.AssertionFailedError: waiting for server up
>>         at org.apache.zookeeper.test.SessionTest.setUp(SessionTest.java:80)
>>         at
>> org.apache.zookeeper.test.SessionTest.testSessionTimeout(SessionTest.java:293)
>>         at
>> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
>>
>> Testcase: testWatcherAutoResetWithLocal took 123.392 sec
>>         FAILED
>> waiting for server up
>> junit.framework.AssertionFailedError: waiting for server up
>>         at
>> org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
>>         at
>> org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
>>         at
>> org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:341)
>>         at
>> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithLocal(WatcherTest.java:242)
>>         at
>> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
>>
>>         FAILED
>> expected:<0> but was:<2>
>> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>>         at
>> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>>         at
>> org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
>>
>> Testcase: testWatcherAutoResetDisabledWithGlobal took 3.16 sec
>>         FAILED
>> expected:<0> but was:<2>
>> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>>         at
>> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>>         at
>> org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:278)
>>         at
>> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithGlobal(WatcherTest.java:233)
>>         at
>> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithGlobal(WatcherTest.java:249)
>>         at
>> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
>>
>>         FAILED
>> expected:<0> but was:<2>
>> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>>         at
>> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>>         at
>> org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
>>
>> Testcase: testWatcherAutoResetDisabledWithLocal took 120.027 sec
>>         FAILED
>> waiting for server up
>> junit.framework.AssertionFailedError: waiting for server up
>>         at
>> org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
>>         at
>> org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
>>         at org.apache.zookeeper.test.ClientBase.setUp(ClientBase.java:408)
>>         at org.apache.zookeeper.test.WatcherTest.setUp(WatcherTest.java:74)
>>
>>         FAILED
>> expected:<0> but was:<2>
>> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>>         at
>> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>>         at
>> org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
>> {noformat}
>>
>> > Upgrade netty version
>> > ---------------------
>> >
>> >                 Key: ZOOKEEPER-1715
>> >                 URL:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1715
>> >             Project: ZooKeeper
>> >          Issue Type: Improvement
>> >    Affects Versions: 3.4.5
>> >         Environment: zookeeper 3.4.5 uses netty 3.2.2, which was
>> released in August 2010.  The latest version of netty is 3.6.6 released May
>> 2013.  Zookeeper should consider upgrading.
>> >            Reporter: Sean Bridges
>> >            Assignee: Sean Bridges
>> >             Fix For: 3.4.6, 3.5.0
>> >
>> >         Attachments: ZOOKEEPER-1715-2.patch, ZOOKEEPER-1715-v3.patch,
>> ZOOKEEPER-1715.patch, zookeeper-1715.patch
>> >
>> >
>> > Upgrade netty version
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.1.4#6159)
>>

Re: [jira] [Commented] (ZOOKEEPER-1715) Upgrade netty version

Posted by German Blanco <ge...@gmail.com>.
The JMXEnv.ensureOnly assertions are covered in ZOOKEEPER-1837.
Still investigating the issue though.


On Sat, Dec 14, 2013 at 12:47 AM, Michi Mutsuzaki (JIRA) <ji...@apache.org>wrote:

>
>     [
> https://issues.apache.org/jira/browse/ZOOKEEPER-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848070#comment-13848070]
>
> Michi Mutsuzaki commented on ZOOKEEPER-1715:
> --------------------------------------------
>
> The timeout issue is fixed with this patch, but I got some failures:
>
> {noformat}
> Testcase: testDisconnectedAddAuth took 121.339 sec
>         FAILED
> waiting for server being up
> junit.framework.AssertionFailedError: waiting for server being up
>         at
> org.apache.zookeeper.test.ACLTest.testDisconnectedAddAuth(ACLTest.java:63)
>         at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> Testcase: testSessionTimeout took 134.221 sec
>         FAILED
> waiting for server up
> junit.framework.AssertionFailedError: waiting for server up
>         at org.apache.zookeeper.test.SessionTest.setUp(SessionTest.java:80)
>         at
> org.apache.zookeeper.test.SessionTest.testSessionTimeout(SessionTest.java:293)
>         at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
>
> Testcase: testWatcherAutoResetWithLocal took 123.392 sec
>         FAILED
> waiting for server up
> junit.framework.AssertionFailedError: waiting for server up
>         at
> org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
>         at
> org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
>         at
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:341)
>         at
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithLocal(WatcherTest.java:242)
>         at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
>
>         FAILED
> expected:<0> but was:<2>
> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>         at
> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>         at
> org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
>
> Testcase: testWatcherAutoResetDisabledWithGlobal took 3.16 sec
>         FAILED
> expected:<0> but was:<2>
> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>         at
> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>         at
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:278)
>         at
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithGlobal(WatcherTest.java:233)
>         at
> org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithGlobal(WatcherTest.java:249)
>         at
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
>
>         FAILED
> expected:<0> but was:<2>
> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>         at
> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>         at
> org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
>
> Testcase: testWatcherAutoResetDisabledWithLocal took 120.027 sec
>         FAILED
> waiting for server up
> junit.framework.AssertionFailedError: waiting for server up
>         at
> org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
>         at
> org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
>         at org.apache.zookeeper.test.ClientBase.setUp(ClientBase.java:408)
>         at org.apache.zookeeper.test.WatcherTest.setUp(WatcherTest.java:74)
>
>         FAILED
> expected:<0> but was:<2>
> junit.framework.AssertionFailedError: expected:<0> but was:<2>
>         at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
>         at
> org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
>         at
> org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
> {noformat}
>
> > Upgrade netty version
> > ---------------------
> >
> >                 Key: ZOOKEEPER-1715
> >                 URL:
> https://issues.apache.org/jira/browse/ZOOKEEPER-1715
> >             Project: ZooKeeper
> >          Issue Type: Improvement
> >    Affects Versions: 3.4.5
> >         Environment: zookeeper 3.4.5 uses netty 3.2.2, which was
> released in August 2010.  The latest version of netty is 3.6.6 released May
> 2013.  Zookeeper should consider upgrading.
> >            Reporter: Sean Bridges
> >            Assignee: Sean Bridges
> >             Fix For: 3.4.6, 3.5.0
> >
> >         Attachments: ZOOKEEPER-1715-2.patch, ZOOKEEPER-1715-v3.patch,
> ZOOKEEPER-1715.patch, zookeeper-1715.patch
> >
> >
> > Upgrade netty version
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1.4#6159)
>